Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use memory_cache_key #317

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Do not use memory_cache_key #317

merged 5 commits into from
Feb 11, 2025

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Feb 4, 2025 •
edited
Loading

Description

Do not use memory_cache_key, which was dropped in QCPortal 0.58 and generally not used prior.

Resolves #315

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Do not use memory_cache_key

Status

  • Ready to go

@mattwthompson mattwthompson marked this pull request as ready for review February 10, 2025 21:54
@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.66%. Comparing base (637c823) to head (eae8164).
Report is 2 commits behind head on main.

Additional details and impacted files

@j-wags j-wags merged commit 4bdd088 into main Feb 11, 2025
8 checks passed
@j-wags j-wags deleted the fix-315 branch February 11, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PortalClient no longer accepts memory_cache_key keyword, leading to failing tests
2 participants
@mattwthompson @j-wags