-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs builds #319
Fix docs builds #319
Conversation
.readthedocs.yml
Outdated
sphinx: | ||
configuration: docs/conf.py | ||
fail_on_warning: true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mattwthompson!
Oh, I see the docs builds are hitting some other errors. Well this is still a clear improvement to me. This can be merged as-is, and I've updated the description to clarify that it's a partial resolution, and I'll leave #318 open and in current iteration on zenhub. |
This surfaced several long-standing, not all of which I am able to resolve in an hour and half or so of work:
See remaining warnings: https://app.readthedocs.org/projects/openff-qcsubmit/builds/27150302/ I think these should be dealt with later since this still fixes the original issue (that docs were not building at all) and just adds in more fixes for free |
Description
Partially resolves #318
Todos
Notable points that this PR has either accomplished or will accomplish.
Status