Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip slow CI in nightly runs until failures can be debugged #2004

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
+4 −5
Open

Skip slow CI in nightly runs until failures can be debugged #2004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cec5ea8
try to reproduce schedule CI errors
j-wags Jan 29, 2025
a8706d2
also remove -m arg
j-wags Jan 29, 2025
d4e07a8
print debugging info
j-wags Feb 5, 2025
cdac3ea
more debugging
j-wags Feb 5, 2025
0962bcb
skip type checking
j-wags Feb 5, 2025
91fd2d4
try more syntax fixes
j-wags Feb 7, 2025
6bd6d4f
more debugging
j-wags Feb 7, 2025
6d81009
debugging
j-wags Feb 7, 2025
15d5505
remove potentially conflicting option from pyproject.toml
j-wags Feb 7, 2025
edb0eb0
just drop slow tests altogether
j-wags Feb 7, 2025
44e11e4
downpin mypy
j-wags Feb 7, 2025
927278a
ignore typing error
j-wags Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,9 @@ jobs:
run: |
PYTEST_ARGS+=" --ignore=openff/toolkit/_tests/test_examples.py"
PYTEST_ARGS+=" --ignore=openff/toolkit/_tests/test_links.py"
if [[ "$GITHUB_EVENT_NAME" == "schedule" ]]; then
PYTEST_ARGS+=" -m 'slow or not slow'"
fi

#if [[ "$GITHUB_EVENT_NAME" == "schedule" ]]; then
# PYTEST_ARGS+=" -m 'slow or not slow' "
#fi
python -m pytest --durations=20 $PYTEST_ARGS $COV

- name: Run code snippets in docs
Expand Down
2 changes: 1 addition & 1 deletion openff/toolkit/topology/topology.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1916,7 +1916,7 @@ def to_openmm(
(last_residue.name == atom_residue_name)
and (int(last_residue.id) == int(atom_residue_number))
and (last_residue.insertionCode == atom_insertion_code)
and (chain.id == last_chain.id)
and (chain.id == last_chain.id) # type: ignore[union-attr]
):
residue = last_residue
else:
Expand Down