Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.173.0 #8027

Merged
merged 5 commits into from
Jan 8, 2025
Merged

build: release v6.173.0 #8027

merged 5 commits into from
Jan 8, 2025

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Jan 6, 2025

New

  • feat: multi lang feature #8022
  • build: merge release v6.172.0 to develop #8016
  • build: release v6.172.0 #8015
  • fix: update mongodb binary version to 6 #8032

Dependencies

  • fix(deps): bump fp-ts from 2.16.8 to 2.16.9 #8017

Dev-Dependencies

Tests

Regression

  • Create a new form
  • Observe that Multi Language tab is not visible on settings page

Flag enablement

  • Add betaFlags.multiLangTranslation to user on DB
  • Observe that Multi Language tab is visible on settings page

KenLSM and others added 3 commits December 23, 2024 16:08
build: merge release v6.172.0 to develop
Bumps [fp-ts](https://github.com/gcanti/fp-ts) from 2.16.8 to 2.16.9.
- [Release notes](https://github.com/gcanti/fp-ts/releases)
- [Changelog](https://github.com/gcanti/fp-ts/blob/master/CHANGELOG.md)
- [Commits](https://github.com/gcanti/fp-ts/commits/2.16.9)

---
updated-dependencies:
- dependency-name: fp-ts
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add model fields to represent translations for form fields (#7457)

* feat: add fields in model to represent translations for form fields

* feat: add shared types to represent form field translations

* fix: use unicode locales

* feat: add settings tab and toggle for multi lang feature (#7561)

* feat: add settings tab and toggle for multi lang feature

* feat: add fields to joi validations

* fix: refactor code to address comments

* fix: failing tests

* feat: add tooltip over icons

* feat: add chromatic tests

* feat: add form field list for translation (#7778)

* feat: add model fields to represent translations for form fields (#7457)

* feat: add fields in model to represent translations for form fields

* feat: add shared types to represent form field translations

* fix: use unicode locales

* feat: add settings tab and toggle for multi lang feature (#7561)

* feat: add settings tab and toggle for multi lang feature

* feat: add fields to joi validations

* fix: refactor code to address comments

* fix: failing tests

* feat: add tooltip over icons

* feat: add chromatic tests

* feat: add view to list form fields for translation

* feat: update logic for checking completion of translations and add storybook tests

* chore: uncomment growthbook middleware usage

* chore: update storybook function used

* chore: address comments

* chore: update app router

* feat: add view for translation input (#7895)

* feat: add view for translation input

* fix: refactor code and remove console log statements

* chore: clean up code

* chore: fix alignment of translation input and header

* chore: address comments

* feat: add translations to public form (#7976)

* feat: add model fields to represent translations for form fields (#7457)

* feat: add fields in model to represent translations for form fields

* feat: add shared types to represent form field translations

* fix: use unicode locales

* feat: add settings tab and toggle for multi lang feature (#7561)

* feat: add settings tab and toggle for multi lang feature

* feat: add fields to joi validations

* fix: refactor code to address comments

* fix: failing tests

* feat: add tooltip over icons

* feat: add chromatic tests

* feat: add translations on public form

* fix: missing provider values for preview and template providers

* feat: add fixed translations for yes and no field

* chore: fix code

* chore: remove unused code and add import

* feat: add fixed translations for est time taken string

* chore: remove unnecessary loggin

* feat: add translations for verifiable fields

* chore: fix tests

* feat: add error if user adds less than required translations for form fields with options

* feat: add beta flag for multi language translation feature for admins

* chore: refactor code

* feat: add fixed translations for default placeholders on public form

* feat: add fixed translations for not found label

* feat: add translations for maximum file size label

* feat: add translations for others label

* feat: add fixed translations for add row label

* feat: add translation for prevent submission messages

* fix: make prevent submission translations optional

* fix: tests

* refactor: use i18next to toggle languages

Use i18next to hold currently selected language rather than use our own
internal state flag in PublicFormContext. That way, a form submitter
can control the language used across the entire Form service.

- Rework LanguageControl and PublicFormContext to use i18next to hold
  currently selected language, falling back on `Language.ENGLISH`
- Rework components to lookup current lang from `useTranslation()`, not
  `PublicFormContext.selectedPublicFormLanguage` or prop passing

* fix: stub i18next for YesNo,Email,Verify fields

* refactor(i18n): move translations from `fixedTranslations`

* refactor(i18n): extract hard-coded translations

* feat: add title translations for MyInfo fields

* feat: always default language back to English on CreatePage

* fix: update myInfo translations and address comments

* feat: add custom header to track user selected form language

---------

Co-authored-by: LoneRifle <[email protected]>

---------

Co-authored-by: LoneRifle <[email protected]>
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 6, 2025

Datadog Report

Branch report: release_v6.173.0
Commit report: 54e544d
Test service: formsg

✅ 0 Failed, 1465 Passed, 0 Skipped, 3m 54.05s Total duration (1h 23m 41.95s time saved)

@KenLSM KenLSM merged commit 2d36463 into release-al2 Jan 8, 2025
35 of 36 checks passed
@KenLSM KenLSM deleted the release_v6.173.0 branch January 8, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants