fix: removed invalid connection from null hotels - fix #263 (#264)

* fix: accountId is undefined on connections - fix #263 * fix: removed invalid connection from null hotels - fix #263 * fix: removed invalid connection from null hotels - fix #263
openhotel · Jan 23, 2025 · c43b6cc · c43b6cc
1 parent 087b82e
commit c43b6cc
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 2 deletions.
diff --git a/app/server/src/modules/migrations/2025-01-23--22-00-remove-invalid-connections.migration.ts b/app/server/src/modules/migrations/2025-01-23--22-00-remove-invalid-connections.migration.ts
@@ -0,0 +1,16 @@
+import { Migration, DbMutable } from "@oh/utils";
+
+export default {
+  id: "2025-01-23--22-00-remove-invalid-connections",
+  description: `remove invalid 'connections' from null hotels`,
+  up: async (db: DbMutable) => {
+    const connections = await db.list({
+      prefix: ["integrationsByAccountId"],
+    });
+    for await (const connection of connections) {
+      const hotel = await db.get(["hotels", connection.value.hotelId]);
+      if (!hotel) await db.delete(connection.key);
+    }
+  },
+  down: async (db: DbMutable) => {},
+} as Migration;
diff --git a/app/server/src/modules/migrations/main.ts b/app/server/src/modules/migrations/main.ts
@@ -12,6 +12,7 @@ const MIGRATION_LIST = [
   await import(
     "./2025-01-23--15-15-remove-integrations-by-hotels-by-account-id.migration.ts"
   ),
+  await import("./2025-01-23--22-00-remove-invalid-connections.migration.ts"),
 ];
 
 export const Migrations = (() => {

diff --git a/app/server/src/modules/system/hotels.ts b/app/server/src/modules/system/hotels.ts
@@ -14,7 +14,7 @@ export const hotels = () => {
   ) => {
     return (
       await System.db.list({
-        prefix: ["integrationsByHotelsByAccountId"],
+        prefix: ["integrationsByAccountId"],
       })
     ).filter(({ key }) => key[2] === hotelId && key[3] === integrationId);
   };
@@ -100,8 +100,16 @@ export const hotels = () => {
       hotelsIdList.filter(($hotelId: string) => hotelId !== $hotelId),
     );
 
-    for (const { integrationId } of hotel.integrations)
+    for (const { integrationId } of hotel.integrations) {
+      const accounts = await getAccountsByIntegrationId(hotelId, integrationId);
+
+      for (const {
+        value: { accountId },
+      } of accounts)
+        await System.connections.remove(accountId, hotelId, integrationId);
+
       await System.db.delete(["hotelsByConnectId", integrationId]);
+    }
 
     await System.db.delete(["hotels", hotelId]);
   };