-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restored v1 headers and added same header to new files. #964
Restored v1 headers and added same header to new files. #964
Conversation
Signed-off-by: Pascal Gouedo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All but one of the files changes in this PR are updates to license headers. These look OK and I am approving this PR on that basis.
The change to rtl/cv32e40p_fp_wrapper.sv
adds a new parameter (FPU_ADDMUL_LAT
). I am not in a position to comment on that.
rtl/cv32e40p_fp_wrapper.sv has 2 new parameters (FPU_ADDMUL_LAT and FPU_OTHERS_LAT) with respect to v1 to replace package defines by top level parameters. |
In fact I restored files to v1 headers because between v1 and now I already updated some of them to what I expected to be final headers. |
@pascalgouedo I have reviewed files with the help of your spreadsheet. My understanding is that in case of modified files from V1, you have updated the existing header to add your copyright and in the case of newly created files, you have created the license with Solderpad 2.1. It looks good to me, so I approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pascalgouedo
restoring the original Copyright and adding Dolphin on new one looks good to me, thanks!
No description provided.