-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sail cmake #1258
Sail cmake #1258
Conversation
CI failing until #1229 is merged |
2471bb6
to
8d01b46
Compare
Rebased on top of #1229. Should be good once CI passes (let's wait for the though). |
Seems there were a couple of other things that have broken the installation. Will work on a fix. |
Looks like that generally fixed things, but now it’s failing on Debian 11 because of an incompatible version of cmake (which is exactly what we set up the CI to try and catch). I’ll take a look at whether we need to make changes upstream or just install a newer version of cmake manually. |
Beautiful!
… On Jan 30, 2025, at 6:23 PM, Jordan Carlin ***@***.***> wrote:
Looks like that generally fixed things, but now it’s failing on Debian 11 because of an incompatible version of cmake (which is exactly what we set up the CI to try and catch). I’ll take a look at whether we need to make changes upstream or just install a newer version of cmake manually.
—
Reply to this email directly, view it on GitHub <#1258 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR4AA3YFOGVIT7FP7O7PAE32NLNBZAVCNFSM6AAAAABWFRSNP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRWGE3DAMRYGM>.
You are receiving this because you are subscribed to this thread.
|
Turns out sail does indeed rely on some of the newer features of CMake. I updated the script to directly install the newer version for Debian 11 and Ubuntu 20.04. Hoping we'll get successful CI now. |
Once we merge this we’ll need to update Sail on all our servers or make will start failing because of the rename. |
Sail has updated to using cmake for its build process. The simulator was also renamed to indicate which flen it was compiled with, so a "d" needs to be added to the simulator name. Also install newer CMake on old Debian and Ubuntu distros.