Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sail cmake #1258

Merged
merged 9 commits into from
Jan 31, 2025
Merged

Sail cmake #1258

merged 9 commits into from
Jan 31, 2025

Conversation

jordancarlin
Copy link
Member

@jordancarlin jordancarlin commented Jan 30, 2025

Sail has updated to using cmake for its build process. The simulator was also renamed to indicate which flen it was compiled with, so a "d" needs to be added to the simulator name. Also install newer CMake on old Debian and Ubuntu distros.

@jordancarlin
Copy link
Member Author

CI failing until #1229 is merged

@jordancarlin
Copy link
Member Author

Rebased on top of #1229. Should be good once CI passes (let's wait for the though).

@jordancarlin jordancarlin marked this pull request as draft January 30, 2025 21:33
@jordancarlin
Copy link
Member Author

Seems there were a couple of other things that have broken the installation. Will work on a fix.

@jordancarlin
Copy link
Member Author

Looks like that generally fixed things, but now it’s failing on Debian 11 because of an incompatible version of cmake (which is exactly what we set up the CI to try and catch). I’ll take a look at whether we need to make changes upstream or just install a newer version of cmake manually.

@davidharrishmc
Copy link
Contributor

davidharrishmc commented Jan 31, 2025 via email

@jordancarlin jordancarlin marked this pull request as ready for review January 31, 2025 03:41
@jordancarlin
Copy link
Member Author

Turns out sail does indeed rely on some of the newer features of CMake. I updated the script to directly install the newer version for Debian 11 and Ubuntu 20.04. Hoping we'll get successful CI now.

@jordancarlin
Copy link
Member Author

Once we merge this we’ll need to update Sail on all our servers or make will start failing because of the rename.

@davidharrishmc davidharrishmc merged commit 2653956 into openhwgroup:main Jan 31, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants