Handle zero photon cross sections in IncidentPhoton.from_ace
#2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in #2421 (see my comment there on the root cause). In other places (e.g.,
from_hdf5and the C++ side), we use a hack where zero cross sections are set to exp(-500), which makes them effectively zero but you can still log-log interpolate. This PR adopts that approach forfrom_acefor consistency. I also noticed that the MT value being assigned to pair production when reading data from ACE files was incorrect. It was assigning MT=515 (pair production in electron field, aka triplet production) rather than MT=517 (pair production in nuclear field); I've also fixed that here.