Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding statepoint.get_mesh method for finding a mesh #3212

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Nov 28, 2024

Description

I would find the ability to get a mesh from a statepoint convenient. Searching for a mesh by ID, name or mesh_type would be helpful.

While making this PR I noticed that the mesh returned from a statepoint does not have a name even if one is set when the mesh is created. I added a TODO for adding a test but I think the bug can be fixed in a separate PR.

This is similar to the get_tally method on the statepoint

Fixes # (issue)

Checklist

  • I have performed a self-review of my own code
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@shimwell shimwell requested a review from pshriwise December 16, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants