Write mesh type as a dataset always #3253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #3249, a change that writes the mesh type as an attribute instead of a data set in the statepoint files along with a corresponding update in the
Mesh.from_hdf5
method caused a compatibility issue with statepoint files generated before #3221.Some of the concrete mesh implementations were also writing the type as a dataset, which is why this wasn't caught in CI. These changes return the mesh type to a dataset, now written only from the
Mesh::to_hdf5
method. TheMesh.from_hdf5
method has also been updated accordingly along with the documentation.I'm open to thoughts on how to test this, but none that are straightforward come to mind immediately.
Thanks for the quick notice @shimwell!
Fixes #3249
Checklist
I have added tests that prove my fix is effective or that my feature works (if applicable)