Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Remove location attributes last audit date and location iso code #3

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

NethmiRodrigo
Copy link
Contributor

@NethmiRodrigo NethmiRodrigo commented Feb 7, 2025

This PR removes the attribute 'Last Audit Date' and the `Location ISO code' from the locations metadata in order to fix the issue described here - openmrs/openmrs-distro-referenceapplication#888 (comment)

@wikumChamith
Copy link
Member

@NethmiRodrigo I am getting an error when running with these changes. However, It is not related to this change and if we merge this we'll have to fix it separately.
org.openmrs.api.ValidationException: 'Ubuntu Hospital' failed to validate with reason: activeAttributes: Location ISO Code is required

@NethmiRodrigo
Copy link
Contributor Author

@NethmiRodrigo I am getting an error when running with these changes. However, It is not related to this change and if we merge this we'll have to fix it separately.
org.openmrs.api.ValidationException: 'Ubuntu Hospital' failed to validate with reason: activeAttributes: Location ISO Code is required

@wikumChamith I'll fix both in this. I'm going to try and remove the location ISO code as well and see (its the attribute that we just added)

@NethmiRodrigo NethmiRodrigo changed the title (fix) Remove location attribute last audit date (fix) Remove location attributes last audit date and location iso code Feb 7, 2025
@NethmiRodrigo
Copy link
Contributor Author

Merging this in since adding the attribute type iso code didn't work - #2

@NethmiRodrigo NethmiRodrigo merged commit e004ca3 into main Feb 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants