TRUNK-5852: Provider Domain - Switching from Hibernate Mappings to Annotations #4910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManojLL
reviewed
Feb 6, 2025
Comment on lines
37
to
+48
| public abstract class BaseCustomizableMetadata<A extends Attribute> extends BaseChangeableOpenmrsMetadata implements Customizable<A> { | ||
|
|
||
| @OrderBy("voided asc") | ||
| @BatchSize(size = 100) | ||
| @OneToMany(cascade = CascadeType.ALL, orphanRemoval = true, fetch = FetchType.LAZY) | ||
| @JoinColumn(name = "location_id") | ||
| private Set<A> attributes = new LinkedHashSet<>(); | ||
|
|
||
| /** | ||
| * @see org.openmrs.customdatatype.Customizable#getAttributes() | ||
| */ | ||
| @Override | ||
| public Set<A> getAttributes() { | ||
| return attributes; | ||
| } | ||
|
|
||
| public abstract Set<A> getAttributes(); | ||
| /** | ||
| * @param attributes the attributes to set | ||
| */ | ||
| public void setAttributes(Set<A> attributes) { | ||
| this.attributes = attributes; | ||
| } | ||
| public abstract void setAttributes(Set<A> attributes); | ||
|
|
There was a problem hiding this comment.
why did you make this change?
There was a problem hiding this comment.
Hi @ManojLL , The provider class had to have a different one to many mapping i.e i wanted to add mappedBy parameter in the @onetomany annotation,The problem was i could not override the OneToMany Mapping in base class. So i removed the field in superclass and made getter and setters as abstract and implemented it in base class. The tests were also failing without that. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRUNK-5852: Provider Domain - Switching from Hibernate Mappings to Annotations
Description of what I changed
I have added annotations to Provider Domain and also made some changes to BaseCustomizableMetadata class because the attributes column has different annotations for Location and Provider class.So i made the getters and setters for atrributes as abstract and added different JPA annotations for attributes column in Location and Provider class.
Issue I worked on
see https://openmrs.atlassian.net/browse/TRUNK-5852
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master