Add ability to log in using the default location set on the user #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR / branch was created while looking to support a use case where an implementation did not want to force users to choose login location at the time of logging in, but rather to allow this to be set from their default location user property (and then changed as needed from the UI post-login).
The only real issue with it is that it won't work in a situation where login location is required and this is coming from the default rather than from the request, as the validation happens pre-authentication, not post-authentication, so some thought and changes would need to account for this.
There is no current demand for this feature just just creating a draft PR and leaving it for now.