META-249 Publish any version of package headers #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In consideration, Package headers are published in xml format using xstreams, modifying this class was to bring out the aspect of getting latestSubscriptionHeaderView with groupuuid and version which was already defined . kindly review this PR and your advise is highly appreciated cc. @dkayiwa , @mogoodrich , @mozzy11 |
|
Kindly review this ticket @rkorytkowski @dkayiwa @ibacher |
ibacher
reviewed
Jul 20, 2020
| @@ -103,7 +102,7 @@ public ModelAndView getSubscriptionHeader(Model model, HttpServletRequest reques | |||
| header.setContentUri(PublishUtils.createRelativeURI("../" + pack.getGroupUuid() + "/" + pack.getVersion() | |||
| + "/download")); | |||
| model.addAttribute("header", header); | |||
| return new ModelAndView(subscriptionHeaderView, model.asMap()); | |||
| return new ModelAndView((String) subscriptionHeaderView, model.asMap()); | |||
There was a problem hiding this comment.
Does this actually work? This seems like a weird cast...
ibacher
reviewed
Jul 20, 2020
| @@ -49,13 +48,13 @@ | |||
| * The controller for publish related pages. | |||
| */ | |||
| @Controller(MetadataSharingConsts.MODULE_ID + ".PublishController") | |||
| public class PublishController { | |||
| public class PublishController<GetLatestSubscriptionHeaderView> { | |||
There was a problem hiding this comment.
Do we need the type information here?
ibacher
reviewed
Jul 20, 2020
omod/src/main/java/org/openmrs/module/metadatasharing/web/controller/PublishController.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes that i made were suggested by @rkorytkowski
https://issues.openmrs.org/projects/META/issues/META-249?filter=allopenissues