Skip to content

Commit

Permalink
Explicitly specify the minimum macOS version in the qtcjson library
Browse files Browse the repository at this point in the history
Also don't set the value in more than one place.

Change-Id: Iea1dc1d4e127c12d6333799dda91749eb2d604d4
Reviewed-by: Eike Ziller <[email protected]>
Reviewed-by: Christian Kandeler <[email protected]>
  • Loading branch information
jakepetroules committed Jun 23, 2017
1 parent 2c55c10 commit 7ff4893
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion qbs/imports/QtcProduct.qbs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Product {

Properties {
condition: Utilities.versionCompare(Qt.core.version, "5.7") < 0
cpp.minimumMacosVersion: "10.8"
cpp.minimumMacosVersion: project.minimumMacosVersion
}

cpp.cxxLanguageVersion: "c++14"
Expand Down
1 change: 1 addition & 0 deletions qtcreator.qbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import qbs.FileInfo
Project {
name: "Qt Creator"
minimumQbsVersion: "1.6.0"
property string minimumMacosVersion: "10.8"
property bool withAutotests: qbs.buildVariant === "debug"
property path ide_source_tree: path
property pathList additionalPlugins: []
Expand Down
1 change: 1 addition & 0 deletions src/shared/json/json.qbs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ StaticLibrary {
name: "qtcjson"
Depends { name: "cpp" }
cpp.cxxLanguageVersion: "c++11"
cpp.minimumMacosVersion: project.minimumMacosVersion
files: [
"json.cpp",
"json.h",
Expand Down
7 changes: 7 additions & 0 deletions src/tools/valgrindfake/valgrindfake.qbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import qbs
import qbs.Utilities

CppApplication {
name: "valgrind-fake"
Expand All @@ -7,6 +8,12 @@ CppApplication {
Depends { name: "Qt"; submodules: ["network", "xml"]; }
Depends { name: "qtc" }
cpp.cxxLanguageVersion: "c++11"

Properties {
condition: Utilities.versionCompare(Qt.core.version, "5.7") < 0
cpp.minimumMacosVersion: project.minimumMacosVersion
}

files: [
"main.cpp",
"outputgenerator.h", "outputgenerator.cpp"
Expand Down

0 comments on commit 7ff4893

Please sign in to comment.