Skip to content

Commit

Permalink
OutputPane: Fix wrongly checked button with "Reset to Default"
Browse files Browse the repository at this point in the history
We only want to set the button "checked" if the Output panes are
visible.

Amends b72f9dc

Change-Id: Ia6fd461338086e141dac09ebf47de09c0635b28b
Reviewed-by: Marcus Tillmanns <[email protected]>
  • Loading branch information
e4z9 committed Sep 19, 2023
1 parent 768f12e commit 8a72318
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/plugins/coreplugin/outputpanemanager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,8 @@ void OutputPaneManager::popupMenu()
for (int i = 0; i < g_outputPanes.size(); ++i) {
OutputPaneData &data = g_outputPanes[i];
const bool buttonVisible = data.pane->priorityInStatusBar() >= 0;
const bool paneVisible = currentIndex() == i;
const bool paneVisible = currentIndex() == i
&& OutputPanePlaceHolder::isCurrentVisible();
if (buttonVisible) {
data.button->setChecked(paneVisible);
data.button->setVisible(true);
Expand Down

0 comments on commit 8a72318

Please sign in to comment.