This repository has been archived by the owner on Jun 23, 2024. It is now read-only.
Libtf: Clean up ops hash code and logging handler. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW there aren't any scopes for the commit message workflow to require one, basically everything is |
iabdalkader
force-pushed
the
libtf_clean_up
branch
from
d095be0 to
da15a45
Compare
iabdalkader
force-pushed
the
libtf_clean_up
branch
from
da15a45 to
824dbee
Compare
iabdalkader
changed the title
kwagyeman
approved these changes
Jun 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the details of the logging buffer, like its size and how it's allocated, outside of the library.
py_tfcan determine what to do with the log in runtime, keep the current behavior which is to save the log for exception, or print it, or ignore.