Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove doc comment in Cloudflare get started telling people to use the app router instead of the pages one #55

Conversation

dario-piotrowicz
Copy link
Contributor

Since we're planning to eventually support the pages router let's remove the comment saying not to use it as it might give the impression that we don't want to ever support it

@dario-piotrowicz dario-piotrowicz requested a review from vicb January 24, 2025 18:59
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dario-piotrowicz dario-piotrowicz merged commit 032edf9 into opennextjs:main Jan 24, 2025
1 check passed
@dario-piotrowicz dario-piotrowicz deleted the dario/cloudflare/pages-router-misleading-comment branch January 24, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants