Fix browser warnings #7548
Closed
Fix browser warnings #7548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 7548.yml under folder changelogs/fragments to complete this PR. File still missing. |
1 similar comment
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 7548.yml under folder changelogs/fragments to complete this PR. File still missing. |
github-actions
bot
added
Skip-Changelog
github-actions
bot
removed
the
Skip-Changelog
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7548 +/- ##
===========================================
- Coverage 63.97% 49.09% -14.89%
===========================================
Files 3597 2440 -1157
Lines 78314 53500 -24814
Branches 12351 8923 -3428
===========================================
- Hits 50103 26264 -23839
- Misses 25190 25729 +539
+ Partials 3021 1507 -1514
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kapian1234 <[email protected]>
Kapian1234
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
Kapian1234
requested review from
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi and
sejli
as code owners
ruanyl
pushed a commit
that referenced
this pull request
Aug 7, 2024
* fix warnings Signed-off-by: Kapian1234 <[email protected]> * fix warnings Signed-off-by: Kapian1234 <[email protected]> * Changeset file for PR #7548 created/updated * fix warnings Signed-off-by: Kapian1234 <[email protected]> * Changeset file for PR #7550 created/updated * Modified the expect of addNavLinksToGroup in workspace plugin.test.js Signed-off-by: Kapian1234 <[email protected]> * Modified the expect of addNavLinksToGroup in workspace plugin.test.js Signed-off-by: Kapian1234 <[email protected]> * remove the duplicate changelogs Signed-off-by: Kapian1234 <[email protected]> * Renamed keys to comply with the directory the file is in Signed-off-by: Kapian1234 <[email protected]> --------- Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: Jincheng Wan <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
* fix warnings Signed-off-by: Kapian1234 <[email protected]> * fix warnings Signed-off-by: Kapian1234 <[email protected]> * Changeset file for PR #7548 created/updated * fix warnings Signed-off-by: Kapian1234 <[email protected]> * Changeset file for PR #7550 created/updated * Modified the expect of addNavLinksToGroup in workspace plugin.test.js Signed-off-by: Kapian1234 <[email protected]> * Modified the expect of addNavLinksToGroup in workspace plugin.test.js Signed-off-by: Kapian1234 <[email protected]> * remove the duplicate changelogs Signed-off-by: Kapian1234 <[email protected]> * Renamed keys to comply with the directory the file is in Signed-off-by: Kapian1234 <[email protected]> --------- Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: Jincheng Wan <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit ca89488) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 9, 2024
* fix warnings * fix warnings * Changeset file for PR #7548 created/updated * fix warnings * Changeset file for PR #7550 created/updated * Modified the expect of addNavLinksToGroup in workspace plugin.test.js * Modified the expect of addNavLinksToGroup in workspace plugin.test.js * remove the duplicate changelogs * Renamed keys to comply with the directory the file is in --------- (cherry picked from commit ca89488) Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: Jincheng Wan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
keyprops in ‘PageRender’, ‘setupHome’, and ‘HomeListCard’.Resolved 'intl' object not found error by using i18n.translate.
Resolved the issue of duplicate 'addNavLinksToGroup' calls to prevent the "Navlink of workspace_list has already been registered in group settingsAndSetup".
Issues Resolved
#7515
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration