Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Essential/Analytics(All) use case overview page #7673

Merged
merged 29 commits into from
Aug 27, 2024

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Aug 9, 2024

Description

Add essential and analytics(All) use case overview page for workspace

alerts/threats card will register by alerting plugin at later

Issues Resolved

#7653

Screenshot

Essential use case overview page
image

Analytics all use case overview page
image

Testing the changes

Changelog

  • feat: [Workspace]Essential/Analytics(All) use case overview page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Aug 9, 2024
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Aug 9, 2024
Signed-off-by: Hailong Cui <[email protected]>

Changeset file for PR opensearch-project#7673 created/updated

Signed-off-by: Hailong Cui <[email protected]>

Revert "navigates to use case overview page"

This reverts commit a43f533.

Signed-off-by: Hailong Cui <[email protected]>
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 66.03774% with 36 lines in your changes missing coverage. Please review.

Project coverage is 63.86%. Comparing base (04fca30) to head (9255b79).
Report is 148 commits behind head on main.

Files with missing lines Patch % Lines
...ic/components/use_case_overview/setup_overview.tsx 57.14% 11 Missing and 1 partial ⚠️
src/plugins/workspace/public/plugin.ts 47.61% 10 Missing and 1 partial ⚠️
...nt_management/public/components/section_render.tsx 25.00% 2 Missing and 1 partial ⚠️
...blic/components/card_container/card_embeddable.tsx 66.66% 0 Missing and 2 partials ⚠️
...rc/plugins/home/public/application/home_render.tsx 0.00% 2 Missing ⚠️
src/plugins/home/public/plugin.ts 0.00% 2 Missing ⚠️
...s/content_management/content_management_service.ts 88.88% 0 Missing and 1 partial ⚠️
...e/public/application/components/home_list_card.tsx 90.00% 1 Missing ⚠️
...cation/components/sample_data/sample_data_card.tsx 80.00% 1 Missing ⚠️
.../plugins/saved_objects_management/public/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7673      +/-   ##
==========================================
+ Coverage   63.83%   63.86%   +0.02%     
==========================================
  Files        3661     3665       +4     
  Lines       81362    81441      +79     
  Branches    12982    12994      +12     
==========================================
+ Hits        51941    52010      +69     
- Misses      26235    26243       +8     
- Partials     3186     3188       +2     
Flag Coverage Δ
Linux_1 30.19% <44.33%> (+0.03%) ⬆️
Linux_2 55.88% <100.00%> (+<0.01%) ⬆️
Linux_3 40.39% <53.06%> (+<0.01%) ⬆️
Linux_4 31.37% <46.93%> (+0.02%) ⬆️
Windows_1 30.23% <44.33%> (+0.05%) ⬆️
Windows_2 55.83% <100.00%> (+<0.01%) ⬆️
Windows_3 40.40% <53.06%> (+<0.01%) ⬆️
Windows_4 31.37% <46.93%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Hailong Cui <[email protected]>

Changeset file for PR opensearch-project#7673 created/updated

Signed-off-by: Hailong Cui <[email protected]>

Revert "navigates to use case overview page"

This reverts commit a43f533.

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
@Hailong-am Hailong-am changed the title [Workspace]Essential use case overview page [Workspace]Essential/Analytics(All) use case overview page Aug 20, 2024
SuZhou-Joe
SuZhou-Joe previously approved these changes Aug 26, 2024
ruanyl
ruanyl previously approved these changes Aug 26, 2024
Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Looks good to me

@Hailong-am Hailong-am dismissed stale reviews from ruanyl and SuZhou-Joe via 9255b79 August 27, 2024 05:28
@SuZhou-Joe SuZhou-Joe merged commit 6931a41 into opensearch-project:main Aug 27, 2024
67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7673-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6931a41432ac03d885e19f3399d4a84fe9093e4c
# Push it to GitHub
git push --set-upstream origin backport/backport-7673-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7673-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 27, 2024
* navigates to use case overview page

Signed-off-by: Hailong Cui <[email protected]>

* Essential use case overviea page

Signed-off-by: Hailong Cui <[email protected]>

Changeset file for PR #7673 created/updated

Signed-off-by: Hailong Cui <[email protected]>

Revert "navigates to use case overview page"

This reverts commit a43f533.

Signed-off-by: Hailong Cui <[email protected]>

* set breadcrumb for overview page

Signed-off-by: Hailong Cui <[email protected]>

* remove width

Signed-off-by: Hailong Cui <[email protected]>

* Analytics use case overview

Signed-off-by: Hailong Cui <[email protected]>

* add unit test

Signed-off-by: Hailong Cui <[email protected]>

* Changeset file for PR #7673 created/updated

* add cardProps for card input

Signed-off-by: Hailong Cui <[email protected]>

* remove repeat license header

Signed-off-by: Hailong Cui <[email protected]>

* navigates to use case overvie page instead of workspace detail

Signed-off-by: Hailong Cui <[email protected]>

* Update src/plugins/content_management/public/components/card_container/card_embeddable.tsx

Co-authored-by: SuZhou-Joe <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>

* update page id to match pattern usecaseId_overview

Signed-off-by: Hailong Cui <[email protected]>

* fix import sample data target area

Signed-off-by: Hailong Cui <[email protected]>

* workspace icon

Signed-off-by: Hailong Cui <[email protected]>

* move all content ids to content management plugin

Signed-off-by: Hailong Cui <[email protected]>

* refactor whats_new and learn opensearch

Signed-off-by: Hailong Cui <[email protected]>

* fix merge issue

Signed-off-by: Hailong Cui <[email protected]>

* fix merge issue

Signed-off-by: Hailong Cui <[email protected]>

* unify use case page content id

Signed-off-by: Hailong Cui <[email protected]>

* add unit test

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <[email protected]>
(cherry picked from commit 6931a41)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Aug 28, 2024
…7862)

* navigates to use case overview page



* Essential use case overviea page



Changeset file for PR #7673 created/updated



Revert "navigates to use case overview page"

This reverts commit a43f533.



* set breadcrumb for overview page



* remove width



* Analytics use case overview



* add unit test



* Changeset file for PR #7673 created/updated

* add cardProps for card input



* remove repeat license header



* navigates to use case overvie page instead of workspace detail



* Update src/plugins/content_management/public/components/card_container/card_embeddable.tsx




* update page id to match pattern usecaseId_overview



* fix import sample data target area



* workspace icon



* move all content ids to content management plugin



* refactor whats_new and learn opensearch



* fix merge issue



* fix merge issue



* unify use case page content id



* add unit test



---------




(cherry picked from commit 6931a41)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <[email protected]>
neodescis added a commit to icr-cognos/OpenSearch-Dashboards that referenced this pull request Sep 12, 2024
[Workspace]Essential/Analytics(All) use case overview page (opensearch-project#7673)

See merge request cognos/OpenSearch-Dashboards!11
@AMoo-Miki
Copy link
Collaborator

Manually backported to 2.x with #7862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants