Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discover] update interfaces and selector #7835

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Aug 25, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

kavilla and others added 23 commits August 22, 2024 20:43
Signed-off-by: Ashwin P Chandran <[email protected]>

fixes loading state

Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>

no more white screen

Signed-off-by: Kawika Avilla <[email protected]>

updating handler

Signed-off-by: Kawika Avilla <[email protected]>

rendering data

Signed-off-by: Kawika Avilla <[email protected]>

data structures working ok

Signed-off-by: Kawika Avilla <[email protected]>

need to add datasets

Signed-off-by: Kawika Avilla <[email protected]>

clean up

Signed-off-by: Kawika Avilla <[email protected]>

deleted unneeded types

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 6.80628% with 178 lines in your changes missing coverage. Please review.

Project coverage is 54.53%. Comparing base (21604e8) to head (2ed09f7).
Report is 1 commits behind head on feature/discover-interfaces.

Files Patch % Lines
...ry/query_string/dataset_service/dataset_service.ts 0.00% 30 Missing ⚠️
...y_string/dataset_service/lib/index_pattern_type.ts 6.45% 29 Missing ⚠️
.../public/query/query_string/query_string_manager.ts 0.00% 27 Missing ⚠️
...ery/query_string/dataset_service/lib/index_type.ts 13.79% 25 Missing ⚠️
...c/plugins/data/common/datasets/_structure_cache.ts 0.00% 11 Missing ⚠️
...blic/ui/search_bar/lib/use_query_string_manager.ts 0.00% 9 Missing ⚠️
.../query_string/language_service/language_service.ts 0.00% 8 Missing ⚠️
src/plugins/data/public/search/search_service.ts 0.00% 7 Missing ⚠️
src/plugins/data/public/ui/settings/settings.ts 0.00% 7 Missing ⚠️
...ublic/query_assist/components/query_assist_bar.tsx 0.00% 5 Missing ⚠️
... and 10 more
Additional details and impacted files
@@                       Coverage Diff                       @@
##           feature/discover-interfaces    #7835      +/-   ##
===============================================================
+ Coverage                        45.88%   54.53%   +8.64%     
===============================================================
  Files                             2745     3259     +514     
  Lines                            62581    71254    +8673     
  Branches                          9783    10949    +1166     
===============================================================
+ Hits                             28716    38855   +10139     
+ Misses                           32592    30324    -2268     
- Partials                          1273     2075     +802     
Flag Coverage Δ
Linux_1 30.16% <6.17%> (?)
Linux_2 55.87% <14.28%> (+0.01%) ⬆️
Windows_1 30.18% <6.17%> (+0.97%) ⬆️
Windows_2 55.82% <14.28%> (+0.01%) ⬆️
Windows_4 31.41% <6.80%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla changed the base branch from main to feature/discover-interfaces August 26, 2024 08:35
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Signed-off-by: Kawika Avilla <[email protected]>
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each of thse commits were reviewed individually as they were built. Reviewed them as a whole too, but briefly. Safe to merge into a feature branch

@kavilla kavilla merged commit 5e6e818 into opensearch-project:feature/discover-interfaces Aug 26, 2024
23 of 53 checks passed
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Aug 26, 2024
* dataset handler and move manager

Signed-off-by: Kawika Avilla <[email protected]>

* Adds new Data selector

Signed-off-by: Ashwin P Chandran <[email protected]>

fixes loading state

Signed-off-by: Ashwin P Chandran <[email protected]>

* start wiring into the selector

Signed-off-by: Kawika Avilla <[email protected]>

no more white screen

Signed-off-by: Kawika Avilla <[email protected]>

updating handler

Signed-off-by: Kawika Avilla <[email protected]>

rendering data

Signed-off-by: Kawika Avilla <[email protected]>

data structures working ok

Signed-off-by: Kawika Avilla <[email protected]>

need to add datasets

Signed-off-by: Kawika Avilla <[email protected]>

clean up

Signed-off-by: Kawika Avilla <[email protected]>

deleted unneeded types

Signed-off-by: Kawika Avilla <[email protected]>

* still working on the data structure and field

Signed-off-by: Kawika Avilla <[email protected]>

* still not working. the leaf logic isnt right i believe

Signed-off-by: Kawika Avilla <[email protected]>

* indices

Signed-off-by: Kawika Avilla <[email protected]>

* pushing datasets

Signed-off-by: Kawika Avilla <[email protected]>

* fix index pattern

Signed-off-by: Kawika Avilla <[email protected]>

* fixes with column

Signed-off-by: Kawika Avilla <[email protected]>

* working creation step

Signed-off-by: Kawika Avilla <[email protected]>

* get dataset from state in use index pattern

Signed-off-by: Kawika Avilla <[email protected]>

* dataset selector working

Signed-off-by: Kawika Avilla <[email protected]>

* update ppl interceptor

Signed-off-by: Kawika Avilla <[email protected]>

* add dataset service

Signed-off-by: Kawika Avilla <[email protected]>

* language service

Signed-off-by: Kawika Avilla <[email protected]>

* wired up but the dataset is off

Signed-off-by: Kawika Avilla <[email protected]>

* Address review comments

Signed-off-by: Kawika Avilla <[email protected]>

* ppl query

Signed-off-by: Kawika Avilla <[email protected]>

* dql and lucene working again

Signed-off-by: Kawika Avilla <[email protected]>

* fix issue that would deselect dataset

Signed-off-by: Kawika Avilla <[email protected]>

* language switches and sets the query correctly

Signed-off-by: Kawika Avilla <[email protected]>

* upating query

Signed-off-by: Kawika Avilla <[email protected]>

* fix the styling a little

Signed-off-by: Kawika Avilla <[email protected]>

* little bit width

Signed-off-by: Kawika Avilla <[email protected]>

* submit on update

Signed-off-by: Kawika Avilla <[email protected]>

* fix sql

Signed-off-by: Kawika Avilla <[email protected]>

* ppl working better

Signed-off-by: Kawika Avilla <[email protected]>

* need to still fix the aggregations

Signed-off-by: Kawika Avilla <[email protected]>

* gotta fix the aggs and still need to update dql lucene dataset

Signed-off-by: Kawika Avilla <[email protected]>

* use patch

Signed-off-by: Kawika Avilla <[email protected]>

* Metadata slice

Signed-off-by: Kawika Avilla <[email protected]>

* index pattern updates

Signed-off-by: Kawika Avilla <[email protected]>

* types and datasource prepend

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
kavilla added a commit that referenced this pull request Aug 27, 2024
* dataset handler and move manager

Signed-off-by: Kawika Avilla <[email protected]>

* Adds new Data selector

Signed-off-by: Ashwin P Chandran <[email protected]>

fixes loading state

Signed-off-by: Ashwin P Chandran <[email protected]>

* start wiring into the selector

Signed-off-by: Kawika Avilla <[email protected]>

no more white screen

Signed-off-by: Kawika Avilla <[email protected]>

updating handler

Signed-off-by: Kawika Avilla <[email protected]>

rendering data

Signed-off-by: Kawika Avilla <[email protected]>

data structures working ok

Signed-off-by: Kawika Avilla <[email protected]>

need to add datasets

Signed-off-by: Kawika Avilla <[email protected]>

clean up

Signed-off-by: Kawika Avilla <[email protected]>

deleted unneeded types

Signed-off-by: Kawika Avilla <[email protected]>

* still working on the data structure and field

Signed-off-by: Kawika Avilla <[email protected]>

* still not working. the leaf logic isnt right i believe

Signed-off-by: Kawika Avilla <[email protected]>

* indices

Signed-off-by: Kawika Avilla <[email protected]>

* pushing datasets

Signed-off-by: Kawika Avilla <[email protected]>

* fix index pattern

Signed-off-by: Kawika Avilla <[email protected]>

* fixes with column

Signed-off-by: Kawika Avilla <[email protected]>

* working creation step

Signed-off-by: Kawika Avilla <[email protected]>

* get dataset from state in use index pattern

Signed-off-by: Kawika Avilla <[email protected]>

* dataset selector working

Signed-off-by: Kawika Avilla <[email protected]>

* update ppl interceptor

Signed-off-by: Kawika Avilla <[email protected]>

* add dataset service

Signed-off-by: Kawika Avilla <[email protected]>

* language service

Signed-off-by: Kawika Avilla <[email protected]>

* wired up but the dataset is off

Signed-off-by: Kawika Avilla <[email protected]>

* Address review comments

Signed-off-by: Kawika Avilla <[email protected]>

* ppl query

Signed-off-by: Kawika Avilla <[email protected]>

* dql and lucene working again

Signed-off-by: Kawika Avilla <[email protected]>

* fix issue that would deselect dataset

Signed-off-by: Kawika Avilla <[email protected]>

* language switches and sets the query correctly

Signed-off-by: Kawika Avilla <[email protected]>

* upating query

Signed-off-by: Kawika Avilla <[email protected]>

* fix the styling a little

Signed-off-by: Kawika Avilla <[email protected]>

* little bit width

Signed-off-by: Kawika Avilla <[email protected]>

* submit on update

Signed-off-by: Kawika Avilla <[email protected]>

* fix sql

Signed-off-by: Kawika Avilla <[email protected]>

* ppl working better

Signed-off-by: Kawika Avilla <[email protected]>

* need to still fix the aggregations

Signed-off-by: Kawika Avilla <[email protected]>

* gotta fix the aggs and still need to update dql lucene dataset

Signed-off-by: Kawika Avilla <[email protected]>

* use patch

Signed-off-by: Kawika Avilla <[email protected]>

* Metadata slice

Signed-off-by: Kawika Avilla <[email protected]>

* index pattern updates

Signed-off-by: Kawika Avilla <[email protected]>

* types and datasource prepend

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
kavilla added a commit that referenced this pull request Aug 27, 2024
* dataset handler and move manager

Signed-off-by: Kawika Avilla <[email protected]>

* Adds new Data selector

Signed-off-by: Ashwin P Chandran <[email protected]>

fixes loading state

Signed-off-by: Ashwin P Chandran <[email protected]>

* start wiring into the selector

Signed-off-by: Kawika Avilla <[email protected]>

no more white screen

Signed-off-by: Kawika Avilla <[email protected]>

updating handler

Signed-off-by: Kawika Avilla <[email protected]>

rendering data

Signed-off-by: Kawika Avilla <[email protected]>

data structures working ok

Signed-off-by: Kawika Avilla <[email protected]>

need to add datasets

Signed-off-by: Kawika Avilla <[email protected]>

clean up

Signed-off-by: Kawika Avilla <[email protected]>

deleted unneeded types

Signed-off-by: Kawika Avilla <[email protected]>

* still working on the data structure and field

Signed-off-by: Kawika Avilla <[email protected]>

* still not working. the leaf logic isnt right i believe

Signed-off-by: Kawika Avilla <[email protected]>

* indices

Signed-off-by: Kawika Avilla <[email protected]>

* pushing datasets

Signed-off-by: Kawika Avilla <[email protected]>

* fix index pattern

Signed-off-by: Kawika Avilla <[email protected]>

* fixes with column

Signed-off-by: Kawika Avilla <[email protected]>

* working creation step

Signed-off-by: Kawika Avilla <[email protected]>

* get dataset from state in use index pattern

Signed-off-by: Kawika Avilla <[email protected]>

* dataset selector working

Signed-off-by: Kawika Avilla <[email protected]>

* update ppl interceptor

Signed-off-by: Kawika Avilla <[email protected]>

* add dataset service

Signed-off-by: Kawika Avilla <[email protected]>

* language service

Signed-off-by: Kawika Avilla <[email protected]>

* wired up but the dataset is off

Signed-off-by: Kawika Avilla <[email protected]>

* Address review comments

Signed-off-by: Kawika Avilla <[email protected]>

* ppl query

Signed-off-by: Kawika Avilla <[email protected]>

* dql and lucene working again

Signed-off-by: Kawika Avilla <[email protected]>

* fix issue that would deselect dataset

Signed-off-by: Kawika Avilla <[email protected]>

* language switches and sets the query correctly

Signed-off-by: Kawika Avilla <[email protected]>

* upating query

Signed-off-by: Kawika Avilla <[email protected]>

* fix the styling a little

Signed-off-by: Kawika Avilla <[email protected]>

* little bit width

Signed-off-by: Kawika Avilla <[email protected]>

* submit on update

Signed-off-by: Kawika Avilla <[email protected]>

* fix sql

Signed-off-by: Kawika Avilla <[email protected]>

* ppl working better

Signed-off-by: Kawika Avilla <[email protected]>

* need to still fix the aggregations

Signed-off-by: Kawika Avilla <[email protected]>

* gotta fix the aggs and still need to update dql lucene dataset

Signed-off-by: Kawika Avilla <[email protected]>

* use patch

Signed-off-by: Kawika Avilla <[email protected]>

* Metadata slice

Signed-off-by: Kawika Avilla <[email protected]>

* index pattern updates

Signed-off-by: Kawika Avilla <[email protected]>

* types and datasource prepend

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
kavilla added a commit that referenced this pull request Aug 27, 2024
…ges (#7731)

* Initial updates to new interfaces Discover expects

Signed-off-by: Kawika Avilla <[email protected]>

* [discover] update interfaces and move dataset manager (#7745)

* Move dataset location

Signed-off-by: Kawika Avilla <[email protected]>

* update interfaces

Signed-off-by: Kawika Avilla <[email protected]>

* Update src/plugins/data/common/datasets/types.ts

Co-authored-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>

* fix rebase errors

Signed-off-by: abbyhu2000 <[email protected]>

* [discover] update interfaces and selector (#7835)

* dataset handler and move manager

Signed-off-by: Kawika Avilla <[email protected]>

* Adds new Data selector

Signed-off-by: Ashwin P Chandran <[email protected]>

fixes loading state

Signed-off-by: Ashwin P Chandran <[email protected]>

* start wiring into the selector

Signed-off-by: Kawika Avilla <[email protected]>

no more white screen

Signed-off-by: Kawika Avilla <[email protected]>

updating handler

Signed-off-by: Kawika Avilla <[email protected]>

rendering data

Signed-off-by: Kawika Avilla <[email protected]>

data structures working ok

Signed-off-by: Kawika Avilla <[email protected]>

need to add datasets

Signed-off-by: Kawika Avilla <[email protected]>

clean up

Signed-off-by: Kawika Avilla <[email protected]>

deleted unneeded types

Signed-off-by: Kawika Avilla <[email protected]>

* still working on the data structure and field

Signed-off-by: Kawika Avilla <[email protected]>

* still not working. the leaf logic isnt right i believe

Signed-off-by: Kawika Avilla <[email protected]>

* indices

Signed-off-by: Kawika Avilla <[email protected]>

* pushing datasets

Signed-off-by: Kawika Avilla <[email protected]>

* fix index pattern

Signed-off-by: Kawika Avilla <[email protected]>

* fixes with column

Signed-off-by: Kawika Avilla <[email protected]>

* working creation step

Signed-off-by: Kawika Avilla <[email protected]>

* get dataset from state in use index pattern

Signed-off-by: Kawika Avilla <[email protected]>

* dataset selector working

Signed-off-by: Kawika Avilla <[email protected]>

* update ppl interceptor

Signed-off-by: Kawika Avilla <[email protected]>

* add dataset service

Signed-off-by: Kawika Avilla <[email protected]>

* language service

Signed-off-by: Kawika Avilla <[email protected]>

* wired up but the dataset is off

Signed-off-by: Kawika Avilla <[email protected]>

* Address review comments

Signed-off-by: Kawika Avilla <[email protected]>

* ppl query

Signed-off-by: Kawika Avilla <[email protected]>

* dql and lucene working again

Signed-off-by: Kawika Avilla <[email protected]>

* fix issue that would deselect dataset

Signed-off-by: Kawika Avilla <[email protected]>

* language switches and sets the query correctly

Signed-off-by: Kawika Avilla <[email protected]>

* upating query

Signed-off-by: Kawika Avilla <[email protected]>

* fix the styling a little

Signed-off-by: Kawika Avilla <[email protected]>

* little bit width

Signed-off-by: Kawika Avilla <[email protected]>

* submit on update

Signed-off-by: Kawika Avilla <[email protected]>

* fix sql

Signed-off-by: Kawika Avilla <[email protected]>

* ppl working better

Signed-off-by: Kawika Avilla <[email protected]>

* need to still fix the aggregations

Signed-off-by: Kawika Avilla <[email protected]>

* gotta fix the aggs and still need to update dql lucene dataset

Signed-off-by: Kawika Avilla <[email protected]>

* use patch

Signed-off-by: Kawika Avilla <[email protected]>

* Metadata slice

Signed-off-by: Kawika Avilla <[email protected]>

* index pattern updates

Signed-off-by: Kawika Avilla <[email protected]>

* types and datasource prepend

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>

* Use language service to render query editor (#7848)

* progress

Signed-off-by: abbyhu2000 <[email protected]>

* get rid of setting class

Signed-off-by: abbyhu2000 <[email protected]>

* register editor inside language

Signed-off-by: abbyhu2000 <[email protected]>

* address commits

Signed-off-by: abbyhu2000 <[email protected]>

* address more comments

Signed-off-by: abbyhu2000 <[email protected]>

* change editor

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>

* minor fixes (#7850)

Signed-off-by: Ashwin P Chandran <[email protected]>

* [discover] Updates to mocks for tests and ci (#7852)

* update manager

Signed-off-by: Kawika Avilla <[email protected]>

* Extension passing

Signed-off-by: Kawika Avilla <[email protected]>

* mock getIndexPatterns

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>

* include create and save

Signed-off-by: Kawika Avilla <[email protected]>

* Fix Nav Bar layout in New Discover (#7853)

* Fix Nav Bar layout in New Discover

Signed-off-by: Suchit Sahoo <[email protected]>

* Changeset file for PR #7853 created/updated

---------

Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [discover] keep fixing mocks (#7855)

* Updating mocks still

Signed-off-by: Kawika Avilla <[email protected]>

* Keep fixing mocks

Signed-off-by: Kawika Avilla <[email protected]>

* update to not use getter

Signed-off-by: Kawika Avilla <[email protected]>

* fix the query being updated twice

Signed-off-by: Kawika Avilla <[email protected]>

* update snapshot

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>

* fix remaining failures

Signed-off-by: Kawika Avilla <[email protected]>

* manual changelog

Signed-off-by: Kawika Avilla <[email protected]>

* update snapshot

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: abbyhu2000 <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Aug 27, 2024
…ges (opensearch-project#7731)

* Initial updates to new interfaces Discover expects

Signed-off-by: Kawika Avilla <[email protected]>

* [discover] update interfaces and move dataset manager (opensearch-project#7745)

* Move dataset location

Signed-off-by: Kawika Avilla <[email protected]>

* update interfaces

Signed-off-by: Kawika Avilla <[email protected]>

* Update src/plugins/data/common/datasets/types.ts

Co-authored-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>

* fix rebase errors

Signed-off-by: abbyhu2000 <[email protected]>

* [discover] update interfaces and selector (opensearch-project#7835)

* dataset handler and move manager

Signed-off-by: Kawika Avilla <[email protected]>

* Adds new Data selector

Signed-off-by: Ashwin P Chandran <[email protected]>

fixes loading state

Signed-off-by: Ashwin P Chandran <[email protected]>

* start wiring into the selector

Signed-off-by: Kawika Avilla <[email protected]>

no more white screen

Signed-off-by: Kawika Avilla <[email protected]>

updating handler

Signed-off-by: Kawika Avilla <[email protected]>

rendering data

Signed-off-by: Kawika Avilla <[email protected]>

data structures working ok

Signed-off-by: Kawika Avilla <[email protected]>

need to add datasets

Signed-off-by: Kawika Avilla <[email protected]>

clean up

Signed-off-by: Kawika Avilla <[email protected]>

deleted unneeded types

Signed-off-by: Kawika Avilla <[email protected]>

* still working on the data structure and field

Signed-off-by: Kawika Avilla <[email protected]>

* still not working. the leaf logic isnt right i believe

Signed-off-by: Kawika Avilla <[email protected]>

* indices

Signed-off-by: Kawika Avilla <[email protected]>

* pushing datasets

Signed-off-by: Kawika Avilla <[email protected]>

* fix index pattern

Signed-off-by: Kawika Avilla <[email protected]>

* fixes with column

Signed-off-by: Kawika Avilla <[email protected]>

* working creation step

Signed-off-by: Kawika Avilla <[email protected]>

* get dataset from state in use index pattern

Signed-off-by: Kawika Avilla <[email protected]>

* dataset selector working

Signed-off-by: Kawika Avilla <[email protected]>

* update ppl interceptor

Signed-off-by: Kawika Avilla <[email protected]>

* add dataset service

Signed-off-by: Kawika Avilla <[email protected]>

* language service

Signed-off-by: Kawika Avilla <[email protected]>

* wired up but the dataset is off

Signed-off-by: Kawika Avilla <[email protected]>

* Address review comments

Signed-off-by: Kawika Avilla <[email protected]>

* ppl query

Signed-off-by: Kawika Avilla <[email protected]>

* dql and lucene working again

Signed-off-by: Kawika Avilla <[email protected]>

* fix issue that would deselect dataset

Signed-off-by: Kawika Avilla <[email protected]>

* language switches and sets the query correctly

Signed-off-by: Kawika Avilla <[email protected]>

* upating query

Signed-off-by: Kawika Avilla <[email protected]>

* fix the styling a little

Signed-off-by: Kawika Avilla <[email protected]>

* little bit width

Signed-off-by: Kawika Avilla <[email protected]>

* submit on update

Signed-off-by: Kawika Avilla <[email protected]>

* fix sql

Signed-off-by: Kawika Avilla <[email protected]>

* ppl working better

Signed-off-by: Kawika Avilla <[email protected]>

* need to still fix the aggregations

Signed-off-by: Kawika Avilla <[email protected]>

* gotta fix the aggs and still need to update dql lucene dataset

Signed-off-by: Kawika Avilla <[email protected]>

* use patch

Signed-off-by: Kawika Avilla <[email protected]>

* Metadata slice

Signed-off-by: Kawika Avilla <[email protected]>

* index pattern updates

Signed-off-by: Kawika Avilla <[email protected]>

* types and datasource prepend

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>

* Use language service to render query editor (opensearch-project#7848)

* progress

Signed-off-by: abbyhu2000 <[email protected]>

* get rid of setting class

Signed-off-by: abbyhu2000 <[email protected]>

* register editor inside language

Signed-off-by: abbyhu2000 <[email protected]>

* address commits

Signed-off-by: abbyhu2000 <[email protected]>

* address more comments

Signed-off-by: abbyhu2000 <[email protected]>

* change editor

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>

* minor fixes (opensearch-project#7850)

Signed-off-by: Ashwin P Chandran <[email protected]>

* [discover] Updates to mocks for tests and ci (opensearch-project#7852)

* update manager

Signed-off-by: Kawika Avilla <[email protected]>

* Extension passing

Signed-off-by: Kawika Avilla <[email protected]>

* mock getIndexPatterns

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>

* include create and save

Signed-off-by: Kawika Avilla <[email protected]>

* Fix Nav Bar layout in New Discover (opensearch-project#7853)

* Fix Nav Bar layout in New Discover

Signed-off-by: Suchit Sahoo <[email protected]>

* Changeset file for PR opensearch-project#7853 created/updated

---------

Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [discover] keep fixing mocks (opensearch-project#7855)

* Updating mocks still

Signed-off-by: Kawika Avilla <[email protected]>

* Keep fixing mocks

Signed-off-by: Kawika Avilla <[email protected]>

* update to not use getter

Signed-off-by: Kawika Avilla <[email protected]>

* fix the query being updated twice

Signed-off-by: Kawika Avilla <[email protected]>

* update snapshot

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>

* fix remaining failures

Signed-off-by: Kawika Avilla <[email protected]>

* manual changelog

Signed-off-by: Kawika Avilla <[email protected]>

* update snapshot

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: abbyhu2000 <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 1976ecf)
ashwin-pc pushed a commit that referenced this pull request Aug 27, 2024
…ges (#7731) (#7863)

* Initial updates to new interfaces Discover expects

Signed-off-by: Kawika Avilla <[email protected]>

* [discover] update interfaces and move dataset manager (#7745)

* Move dataset location

Signed-off-by: Kawika Avilla <[email protected]>

* update interfaces

Signed-off-by: Kawika Avilla <[email protected]>

* Update src/plugins/data/common/datasets/types.ts

Co-authored-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>

* fix rebase errors

Signed-off-by: abbyhu2000 <[email protected]>

* [discover] update interfaces and selector (#7835)

* dataset handler and move manager

Signed-off-by: Kawika Avilla <[email protected]>

* Adds new Data selector

Signed-off-by: Ashwin P Chandran <[email protected]>

fixes loading state

Signed-off-by: Ashwin P Chandran <[email protected]>

* start wiring into the selector

Signed-off-by: Kawika Avilla <[email protected]>

no more white screen

Signed-off-by: Kawika Avilla <[email protected]>

updating handler

Signed-off-by: Kawika Avilla <[email protected]>

rendering data

Signed-off-by: Kawika Avilla <[email protected]>

data structures working ok

Signed-off-by: Kawika Avilla <[email protected]>

need to add datasets

Signed-off-by: Kawika Avilla <[email protected]>

clean up

Signed-off-by: Kawika Avilla <[email protected]>

deleted unneeded types

Signed-off-by: Kawika Avilla <[email protected]>

* still working on the data structure and field

Signed-off-by: Kawika Avilla <[email protected]>

* still not working. the leaf logic isnt right i believe

Signed-off-by: Kawika Avilla <[email protected]>

* indices

Signed-off-by: Kawika Avilla <[email protected]>

* pushing datasets

Signed-off-by: Kawika Avilla <[email protected]>

* fix index pattern

Signed-off-by: Kawika Avilla <[email protected]>

* fixes with column

Signed-off-by: Kawika Avilla <[email protected]>

* working creation step

Signed-off-by: Kawika Avilla <[email protected]>

* get dataset from state in use index pattern

Signed-off-by: Kawika Avilla <[email protected]>

* dataset selector working

Signed-off-by: Kawika Avilla <[email protected]>

* update ppl interceptor

Signed-off-by: Kawika Avilla <[email protected]>

* add dataset service

Signed-off-by: Kawika Avilla <[email protected]>

* language service

Signed-off-by: Kawika Avilla <[email protected]>

* wired up but the dataset is off

Signed-off-by: Kawika Avilla <[email protected]>

* Address review comments

Signed-off-by: Kawika Avilla <[email protected]>

* ppl query

Signed-off-by: Kawika Avilla <[email protected]>

* dql and lucene working again

Signed-off-by: Kawika Avilla <[email protected]>

* fix issue that would deselect dataset

Signed-off-by: Kawika Avilla <[email protected]>

* language switches and sets the query correctly

Signed-off-by: Kawika Avilla <[email protected]>

* upating query

Signed-off-by: Kawika Avilla <[email protected]>

* fix the styling a little

Signed-off-by: Kawika Avilla <[email protected]>

* little bit width

Signed-off-by: Kawika Avilla <[email protected]>

* submit on update

Signed-off-by: Kawika Avilla <[email protected]>

* fix sql

Signed-off-by: Kawika Avilla <[email protected]>

* ppl working better

Signed-off-by: Kawika Avilla <[email protected]>

* need to still fix the aggregations

Signed-off-by: Kawika Avilla <[email protected]>

* gotta fix the aggs and still need to update dql lucene dataset

Signed-off-by: Kawika Avilla <[email protected]>

* use patch

Signed-off-by: Kawika Avilla <[email protected]>

* Metadata slice

Signed-off-by: Kawika Avilla <[email protected]>

* index pattern updates

Signed-off-by: Kawika Avilla <[email protected]>

* types and datasource prepend

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>

* Use language service to render query editor (#7848)

* progress

Signed-off-by: abbyhu2000 <[email protected]>

* get rid of setting class

Signed-off-by: abbyhu2000 <[email protected]>

* register editor inside language

Signed-off-by: abbyhu2000 <[email protected]>

* address commits

Signed-off-by: abbyhu2000 <[email protected]>

* address more comments

Signed-off-by: abbyhu2000 <[email protected]>

* change editor

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>

* minor fixes (#7850)

Signed-off-by: Ashwin P Chandran <[email protected]>

* [discover] Updates to mocks for tests and ci (#7852)

* update manager

Signed-off-by: Kawika Avilla <[email protected]>

* Extension passing

Signed-off-by: Kawika Avilla <[email protected]>

* mock getIndexPatterns

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>

* include create and save

Signed-off-by: Kawika Avilla <[email protected]>

* Fix Nav Bar layout in New Discover (#7853)

* Fix Nav Bar layout in New Discover

Signed-off-by: Suchit Sahoo <[email protected]>

* Changeset file for PR #7853 created/updated

---------

Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [discover] keep fixing mocks (#7855)

* Updating mocks still

Signed-off-by: Kawika Avilla <[email protected]>

* Keep fixing mocks

Signed-off-by: Kawika Avilla <[email protected]>

* update to not use getter

Signed-off-by: Kawika Avilla <[email protected]>

* fix the query being updated twice

Signed-off-by: Kawika Avilla <[email protected]>

* update snapshot

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>

* fix remaining failures

Signed-off-by: Kawika Avilla <[email protected]>

* manual changelog

Signed-off-by: Kawika Avilla <[email protected]>

* update snapshot

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: abbyhu2000 <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 1976ecf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants