Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TESTID-140: sidebar spec #9128

Closed
wants to merge 27 commits into from
Closed

TESTID-140: sidebar spec #9128

wants to merge 27 commits into from
+437 −0

Conversation

silvaf-dev
Copy link
Contributor

@silvaf-dev silvaf-dev commented Dec 26, 2024 •
edited
Loading

Description

Implements all four test suites required by #8946

Issues Resolved

Screenshot

Screen.Recording.2025-01-08.at.11.1.mp4

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions github-actions bot added first-time-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Dec 26, 2024
@angle943
Copy link
Contributor

Could you rebase so that the diff only show your changes?

@silvaf-dev
Copy link
Contributor Author

silvaf-dev commented Dec 30, 2024 •
edited
Loading

Could you rebase so that the diff only show your changes?

Done, but it'll still contain more changes than the ones I authored. The reason is I had to pull from Argus' PR in order to recover my lost refactors.
The files I modified were:

  • cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/sidebar_filtering.spec.js
  • src/plugins/data_explorer/public/components/sidebar/index.tsx (added data-test-subj)
  • cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/helpers.js (added my functions below verifyDocTableFirstExpandedFieldFirstRowExistsFilterButtonFiltersCorrectField())
  • cypress.config.ts (added a retry)

silvaf-dev and others added 14 commits January 7, 2025 17:05
@silvaf-dev
fix first test suite
a9de253 
Signed-off-by: Federico Silva <[email protected]>
@silvaf-dev
update selectIndexDataset cmd
4e733c2 
Signed-off-by: Federico Silva <[email protected]>
@ArgusLi @silvaf-dev
fix tests
db51987 
Signed-off-by: Federico Silva <[email protected]>
@silvaf-dev
sign off commits
cc6117d 
Signed-off-by: Federico Silva <[email protected]>
@silvaf-dev
fix 4th test suite
5a36454 
Signed-off-by: Federico Silva <[email protected]>
@silvaf-dev
address pr comments
b264cb8 
Signed-off-by: Federico Silva <[email protected]>
@silvaf-dev
remove helper function to set the query language and use the custom c…
8de04d2 
…ommand instead

Signed-off-by: Federico Silva <[email protected]>
@silvaf-dev
delete testid-69-specific changes to avoid future merge conflicts
b3b3779 
Signed-off-by: Federico Silva <[email protected]>
@silvaf-dev
remove unnecesary files
5be6c53 
Signed-off-by: Federico Silva <[email protected]>
@silvaf-dev
remove LOC on forEach loops
f1d9780 
Signed-off-by: Federico Silva <[email protected]>
@ArgusLi @opensearch-changeset-bot @silvaf-dev
[Discover 2.0 Testing] Create Filtering Test (TestId-69: Filtering) (o…
a7023ac 
…pensearch-project#9119)

* Add test for filtering functionality for discover, which enables query enhancement
* Make test more robust: Add logic to use date picker start and end buttons if set to absolute times. Check the table length directly instead of number of hits to avoid bug where not all results load.

---------

Signed-off-by: Argus Li <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>
@Qxisylolo @opensearch-changeset-bot @silvaf-dev
[Workspace] fix:Prevent user from visiting dashboards / visualization…
dcaa54b 
…s when out of a workspace (opensearch-project#9024)

* add workspaceAvailability

Signed-off-by: Qxisylolo <[email protected]>

* Changeset file for PR opensearch-project#9024 created/updated

* add tests

Signed-off-by: Qxisylolo <[email protected]>

* update test

Signed-off-by: Qxisylolo <[email protected]>

* fix test use piple

Signed-off-by: Qxisylolo <[email protected]>

* fix test new

Signed-off-by: Qxisylolo <[email protected]>

---------

Signed-off-by: Qxisylolo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>
@angle943 @opensearch-changeset-bot
@ananzh @silvaf-dev
Add tests for saved search creation and loading for query enhancement (…
a6566ba 
…opensearch-project#9112)

* Add tests for saved search creation and loading for query enhancement
* click on a random element before typing on query editor to bypass the popover that appears
* address pr comments - refactor to create saved search as an api call
* address pr comments - specifically navigate to discover page before setting datasource

Signed-off-by: Justin Kim <[email protected]>

---------

Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Anan Zhuang <[email protected]>
Signed-off-by: Federico Silva <[email protected]>
@silvaf-dev
refactor after review
e370408 
Signed-off-by: Federico Silva <[email protected]>
@ananzh
Copy link
Member

ananzh commented Jan 7, 2025

@silvaf-dev from https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/12658896186/job/35276829002?pr=9128, it seems that this cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/utils/sidebar_filtering.js is missing license header and there are some lint issues. Could you add a license header and also run yarn lint --fix to fix?

ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jan 8, 2025
@ananzh
Refactor TESTID 140 and clean up
7ff00bb 
* Refactor this PR opensearch-project#9128
* Clean up structures

Signed-off-by: Anan <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jan 8, 2025
@ananzh
Refactor TESTID 140 and clean up
1dfcd34 
* Refactor this PR opensearch-project#9128
* Clean up structures

Signed-off-by: Anan <[email protected]>
@ananzh ananzh mentioned this pull request Jan 8, 2025
Merged
7 tasks
@ananzh ananzh added the discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative label Jan 17, 2025
@ananzh
Copy link
Member

ananzh commented Jan 28, 2025

Close it as it is refactored by #9154

@ananzh ananzh closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh left review comments

@angle943 angle943 angle943 requested changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative first-time-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@silvaf-dev @angle943 @ananzh @ArgusLi @Qxisylolo