[Backport 2.x] [workspace]fix the bug that mistakenly classify data connection #9256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* fix the bug that mistakely miscategorify data connection Signed-off-by: Qxisylolo <[email protected]> * Changeset file for PR #9237 created/updated * [workspace]add 2 step loading in 'Associate data sources' modal (#8999) * add 2 step loading Signed-off-by: Qxisylolo <[email protected]> * Changeset file for PR #8999 created/updated * ifx ut Signed-off-by: Qxisylolo <[email protected]> * resolve comments Signed-off-by: Qxisylolo <[email protected]> * delete functions Signed-off-by: Qxisylolo <[email protected]> * separately fetch dqc Signed-off-by: Qxisylolo <[email protected]> * small mistakes Signed-off-by: Qxisylolo <[email protected]> * dqc should not show data source without dqc Signed-off-by: Qxisylolo <[email protected]> * fix tests Signed-off-by: Qxisylolo <[email protected]> * new update Signed-off-by: Qxisylolo <[email protected]> * delete non-used import Signed-off-by: Qxisylolo <[email protected]> * delete if Signed-off-by: Qxisylolo <[email protected]> * add try catch Signed-off-by: Qxisylolo <[email protected]> --------- Signed-off-by: Qxisylolo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]> * fix the bug that mistakely miscategorify data connection Signed-off-by: Qxisylolo <[email protected]> * fix conflict Signed-off-by: Qxisylolo <[email protected]> * conflicts Signed-off-by: Qxisylolo <[email protected]> * small fix Signed-off-by: Qxisylolo <[email protected]> * typo Signed-off-by: Qxisylolo <[email protected]> * add tests Signed-off-by: Qxisylolo <[email protected]> * delete one Signed-off-by: Qxisylolo <[email protected]> --------- Signed-off-by: Qxisylolo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]> (cherry picked from commit 11918b6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #9256 +/- ##
==========================================
+ Coverage 61.14% 61.15% +0.01%
==========================================
Files 3815 3815
Lines 91528 91504 -24
Branches 14459 14458 -1
==========================================
- Hits 55961 55956 -5
+ Misses 32004 31990 -14
+ Partials 3563 3558 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Jan 23, 2025
ananzh
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 11918b6 from #9237.