Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace]DQC can not be assigned to a workspace due to validation #9258

Closed
wants to merge 11 commits into from
Closed

[Workspace]DQC can not be assigned to a workspace due to validation #9258

wants to merge 11 commits into from

Conversation

Qxisylolo
Copy link
Contributor

Description

This pr

Issues Resolved

Issue: #9257

Screenshot

Uploading 录屏2025-01-23 14.31.09.mov…

Testing the changes

Changelog

  • fix: DQC can not be assigned to a workspace due to validation

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Qxisylolo and others added 11 commits January 22, 2025 11:02
@Qxisylolo
fix the bug that mistakely miscategorify data connection
648764d 
Signed-off-by: Qxisylolo <[email protected]>
@opensearch-changeset-bot @Qxisylolo
Changeset file for PR opensearch-project#9237 created/updated
433c136
@Qxisylolo @opensearch-changeset-bot @ruanyl
[workspace]add 2 step loading in 'Associate data sources' modal (open…
18927e9 
…search-project#8999)

* add 2 step loading

Signed-off-by: Qxisylolo <[email protected]>

* Changeset file for PR opensearch-project#8999 created/updated

* ifx ut

Signed-off-by: Qxisylolo <[email protected]>

* resolve comments

Signed-off-by: Qxisylolo <[email protected]>

* delete functions

Signed-off-by: Qxisylolo <[email protected]>

* separately fetch dqc

Signed-off-by: Qxisylolo <[email protected]>

* small mistakes

Signed-off-by: Qxisylolo <[email protected]>

* dqc should not show data source without dqc

Signed-off-by: Qxisylolo <[email protected]>

* fix tests

Signed-off-by: Qxisylolo <[email protected]>

* new update

Signed-off-by: Qxisylolo <[email protected]>

* delete non-used import

Signed-off-by: Qxisylolo <[email protected]>

* delete if

Signed-off-by: Qxisylolo <[email protected]>

* add try catch

Signed-off-by: Qxisylolo <[email protected]>

---------

Signed-off-by: Qxisylolo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <[email protected]>
@Qxisylolo
fix the bug that mistakely miscategorify data connection
bb6142b 
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo
fix conflict
99cda06 
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo
conflicts
5cd94b1 
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo
small fix
544af30 
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo
typo
d3d8fa8 
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo
add tests
05f74be 
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo
delete one
1a3b805 
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo
try fix
a9dff41 
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo Qxisylolo closed this Jan 23, 2025
opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Jan 23, 2025
@opensearch-changeset-bot
Changeset file for PR opensearch-project#9258 created/updated
45da5b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh Awaiting requested review from ananzh ananzh will be requested when the pull request is marked ready for review ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla will be requested when the pull request is marked ready for review kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki will be requested when the pull request is marked ready for review AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc will be requested when the pull request is marked ready for review ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr will be requested when the pull request is marked ready for review joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 will be requested when the pull request is marked ready for review abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon will be requested when the pull request is marked ready for review zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu will be requested when the pull request is marked ready for review zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs will be requested when the pull request is marked ready for review manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX will be requested when the pull request is marked ready for review ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub will be requested when the pull request is marked ready for review Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq will be requested when the pull request is marked ready for review curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn will be requested when the pull request is marked ready for review bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe will be requested when the pull request is marked ready for review SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl will be requested when the pull request is marked ready for review ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT will be requested when the pull request is marked ready for review BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba will be requested when the pull request is marked ready for review xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi will be requested when the pull request is marked ready for review zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric will be requested when the pull request is marked ready for review mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 will be requested when the pull request is marked ready for review LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi will be requested when the pull request is marked ready for review virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli will be requested when the pull request is marked ready for review sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 will be requested when the pull request is marked ready for review joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo will be requested when the pull request is marked ready for review huyaboo is a code owner

Assignees
No one assigned
Labels
all-star-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Qxisylolo