Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fixing console error when the data source has an empty description #9260

Merged
merged 2 commits into from
Jan 24, 2025
Merged

[Backport 2.x] Fixing console error when the data source has an empty description #9260

merged 2 commits into from
Jan 24, 2025

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 33cb5b7 from #9236.

@github-actions @opensearch-changeset-bot
Fixing console error when the data source has an empty description (#…
0433d71 
…9236)

* fix: add check for data source description and adding tests

Signed-off-by: Owen Wang <[email protected]>

* Changeset file for PR #9236 created/updated

* test: strength the test for data source empty description

Signed-off-by: Owen Wang <[email protected]>

---------

Signed-off-by: Owen Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 33cb5b7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports first-time-contributor workspace v2.19.0 labels Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.14%. Comparing base (0916f05) to head (3ecafac).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...components/data_source_table/data_source_table.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              2.x    #9260   +/-   ##
=======================================
  Coverage   61.14%   61.14%           
=======================================
  Files        3815     3815           
  Lines       91528    91529    +1     
  Branches    14459    14459           
=======================================
+ Hits        55961    55963    +2     
  Misses      32004    32004           
+ Partials     3563     3562    -1
Flag Coverage Δ
Linux_1 29.13% <ø> (ø)
Linux_2 56.60% <ø> (ø)
Linux_3 38.06% <66.66%> (-0.01%) ⬇️
Linux_4 29.18% <ø> (ø)
Windows_1 29.14% <ø> (ø)
Windows_2 56.55% <ø> (ø)
Windows_3 38.06% <66.66%> (+<0.01%) ⬆️
Windows_4 29.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am merged commit d81cb8a into 2.x Jan 24, 2025
66 of 68 checks passed
@github-actions github-actions bot deleted the backport/backport-9236-to-2.x branch January 24, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hailong-am Hailong-am Hailong-am approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports failed changeset first-time-contributor v2.19.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuZhou-Joe @Hailong-am @ananzh