fix data field parsing; use advanceExact()

Signed-off-by: Sandesh Kumar <[email protected]>
opensearch-project · Jan 29, 2025 · 89310be · 89310be
1 parent 1420e07
commit 89310be
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...ain/java/org/opensearch/search/aggregations/bucket/histogram/DateHistogramAggregator.java b/...ain/java/org/opensearch/search/aggregations/bucket/histogram/DateHistogramAggregator.java
@@ -137,8 +137,8 @@ class DateHistogramAggregator extends BucketsAggregator implements SizedBucketAg
         this.hardBounds = hardBounds;
         // TODO: Stop using null here
         this.valuesSource = valuesSourceConfig.hasValues() ? (ValuesSource.Numeric) valuesSourceConfig.getValuesSource() : null;
-        this.fieldName = valuesSourceConfig.hasValues()
-            ? ((ValuesSource.Numeric.FieldData) valuesSourceConfig.getValuesSource()).getIndexFieldName()
+        this.fieldName = (valuesSource instanceof ValuesSource.Numeric.FieldData)
+            ? ((ValuesSource.Numeric.FieldData) valuesSource).getIndexFieldName()
             : null;
         this.formatter = valuesSourceConfig.format();
 

diff --git a/...src/main/java/org/opensearch/search/aggregations/bucket/terms/NumericTermsAggregator.java b/...src/main/java/org/opensearch/search/aggregations/bucket/terms/NumericTermsAggregator.java
@@ -86,7 +86,6 @@
 
 import static java.util.Collections.emptyList;
 import static org.opensearch.search.aggregations.InternalOrder.isKeyOrder;
-import static org.apache.lucene.search.DocIdSetIterator.NO_MORE_DOCS;
 
 /**
  * Aggregate all docs that contain numeric terms
@@ -210,7 +209,7 @@ public void setSubCollectors() throws IOException {
 
             @Override
             public void collectStarTreeEntry(int starTreeEntry, long owningBucketOrd) throws IOException {
-                if (valuesIterator.advance(starTreeEntry) == NO_MORE_DOCS) {
+                if (valuesIterator.advanceExact(starTreeEntry) == false) {
                     return;
                 }
                 long dimensionValue = valuesIterator.nextValue();