Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cancellation start time in client side TaskInfo #10326

Merged

Conversation

sgup432
Copy link
Contributor

@sgup432 sgup432 commented Oct 3, 2023

Description

Adding cancellation start time in client side Task info object. Looks like rest high java client is on deprecation path but still adding it in case it doesn't break stuff.

Original change which was added few months back - #7445.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sgup432
Copy link
Contributor Author

sgup432 commented Oct 3, 2023

@andrross @dblock Can you check on this?
Also do we require change log for this?

@sgup432
Copy link
Contributor Author

sgup432 commented Oct 3, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Compatibility status:

Checks if related components are compatible with change 1774f45

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #10326 (1774f45) into main (28f185b) will increase coverage by 0.12%.
Report is 3 commits behind head on main.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main   #10326      +/-   ##
============================================
+ Coverage     71.09%   71.21%   +0.12%     
- Complexity    58209    58338     +129     
============================================
  Files          4830     4830              
  Lines        274840   274846       +6     
  Branches      40048    40049       +1     
============================================
+ Hits         195384   195721     +337     
+ Misses        63052    62737     -315     
+ Partials      16404    16388      -16     
Files Coverage Δ
...ain/java/org/opensearch/client/tasks/TaskInfo.java 63.04% <50.00%> (+0.25%) ⬆️

... and 441 files with indirect coverage changes

@andrross andrross added the backport 2.x Backport to 2.x branch label Oct 5, 2023
@andrross andrross merged commit 71b6948 into opensearch-project:main Oct 5, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2023
Signed-off-by: Sagar Upadhyaya <[email protected]>
(cherry picked from commit 71b6948)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request Oct 5, 2023
(cherry picked from commit 71b6948)

Signed-off-by: Sagar Upadhyaya <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 9, 2023
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants