Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streaming Indexing] Enhance RestAction with request / response streaming support #13772

Merged
merged 2 commits into from
Jun 10, 2024

Address code review comments

aea22d9
Select commit
Loading
Failed to load commit list.
Merged

[Streaming Indexing] Enhance RestAction with request / response streaming support #13772

Address code review comments
aea22d9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 10, 2024 in 0s

71.57% (target 70.00%)

View this Pull Request on Codecov

71.57% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 45.90747% with 152 lines in your changes missing coverage. Please review.

Project coverage is 71.57%. Comparing base (b15cb0c) to head (aea22d9).
Report is 390 commits behind head on main.

Files Patch % Lines
.../main/java/org/opensearch/rest/RestController.java 1.88% 51 Missing and 1 partial ⚠️
.../rest/action/document/RestBulkStreamingAction.java 31.74% 42 Missing and 1 partial ⚠️
...ctor/netty4/ReactorNetty4StreamingHttpChannel.java 36.84% 23 Missing and 1 partial ⚠️
...g/opensearch/http/DefaultStreamingRestChannel.java 64.28% 7 Missing and 3 partials ⚠️
.../netty4/ReactorNetty4StreamingRequestConsumer.java 61.53% 3 Missing and 2 partials ⚠️
...ch/http/reactor/netty4/ReactorNetty4HttpChunk.java 69.23% 3 Missing and 1 partial ⚠️
...netty4/ReactorNetty4StreamingResponseProducer.java 75.00% 4 Missing ⚠️
.../src/main/java/org/opensearch/http/HttpTracer.java 0.00% 4 Missing ⚠️
...g/opensearch/http/AbstractHttpServerTransport.java 62.50% 3 Missing ⚠️
...rch/common/xcontent/support/XContentHttpChunk.java 83.33% 1 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #13772      +/-   ##
============================================
+ Coverage     71.42%   71.57%   +0.15%     
- Complexity    59978    61714    +1736     
============================================
  Files          4985     5102     +117     
  Lines        282275   289941    +7666     
  Branches      40946    41896     +950     
============================================
+ Hits         201603   207523    +5920     
- Misses        63999    65297    +1298     
- Partials      16673    17121     +448

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov