Skip zone awareness when auto-expand set to all #14619
Conversation
amberzsy
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
enhancement
|
❌ Gradle check result for bf7bf9d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14619 +/- ##
============================================
+ Coverage 71.93% 72.01% +0.07%
- Complexity 64374 64401 +27
============================================
Files 5277 5278 +1
Lines 300828 300879 +51
Branches 43474 43479 +5
============================================
+ Hits 216411 216682 +271
+ Misses 66725 66410 -315
- Partials 17692 17787 +95 ☔ View full report in Codecov by Sentry. |
.../main/java/org/opensearch/cluster/routing/allocation/decider/SameShardAllocationDecider.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for bd2877b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
amberzsy
force-pushed
the
skip_awareness_with_auto_expand_all
branch
from
6a8e7ce to
bd2877b
Compare
|
This PR is stalled because it has been open for 30 days with no activity. |
opensearch-trigger-bot
bot
added
stalled
|
❌ Gradle check result for 0999efa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for fed1096: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
amberzsy
force-pushed
the
skip_awareness_with_auto_expand_all
branch
from
fed1096 to
075ba07
Compare
There was a problem hiding this comment.
Looks good to me. @vikasvb90 can you take another look as well?
|
@amberzsy Can you add a changelog entry? Also, I think the commit message and PR title should be fixed since this is only skipping zone awareness and not host. |
amberzsy
changed the title
amberzsy
force-pushed
the
skip_awareness_with_auto_expand_all
branch
4 times, most recently
from
74ae2bc to
a27c4e3
Compare
|
❕ Gradle check result for 74ae2bc: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
amberzsy
force-pushed
the
skip_awareness_with_auto_expand_all
branch
from
d25ca2a to
1636d3c
Compare
|
❌ Gradle check result for 0194e39: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
amberzsy
force-pushed
the
skip_awareness_with_auto_expand_all
branch
from
a89fee1 to
036f6bc
Compare
Description
Skip zone/host awareness when auto-expand set to "all"
Related Issues
Resolves #14603
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.