Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed suspicious getClass() call on Class #15357

Closed
wants to merge 1 commit into from

Conversation

dk2k
Copy link
Contributor

@dk2k dk2k commented Aug 22, 2024

No description provided.

Copy link
Contributor

❕ Gradle check result for 5b5b8c1: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.83%. Comparing base (abb1041) to head (5b5b8c1).
Report is 312 commits behind head on main.

Files with missing lines Patch % Lines
...rg/opensearch/core/common/io/stream/Writeable.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15357      +/-   ##
============================================
- Coverage     71.93%   71.83%   -0.10%     
+ Complexity    63223    63136      -87     
============================================
  Files          5214     5214              
  Lines        295938   295938              
  Branches      42754    42754              
============================================
- Hits         212876   212592     -284     
- Misses        65601    65893     +292     
+ Partials      17461    17453       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock
Copy link
Member

dblock commented Aug 23, 2024

Thanks! Check whether we have a test that exercises this path, otherwise add one. Sign commits with -s so DCO can pass.

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Sep 23, 2024
@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Sep 24, 2024
@dbwiddis
Copy link
Member

Closing as this was duplicated by #15367 which was replaced by #16002. Fixed in any case.

@dbwiddis dbwiddis closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants