-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WLM] add wlm support for scroll API #16981
[WLM] add wlm support for scroll API #16981
Conversation
❌ Gradle check result for 3c4992e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ce67278: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@kaushalmahi12 Are we missing tests that could have caught this issue? |
@andrross I think it would a good idea to add a test which will cover all the APIs. Let me do that next. |
ce67278
to
0c37980
Compare
❌ Gradle check result for 0c37980: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 745bd3a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 6e5f44d: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16981 +/- ##
============================================
+ Coverage 72.30% 72.36% +0.05%
- Complexity 65482 65503 +21
============================================
Files 5309 5309
Lines 304324 304331 +7
Branches 44132 44133 +1
============================================
+ Hits 220056 220229 +173
+ Misses 66259 66029 -230
- Partials 18009 18073 +64 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
6e5f44d
to
a7b50d3
Compare
Signed-off-by: Kaushal Kumar <[email protected]>
❌ Gradle check result for 6973d28: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16981-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c5ab16264d5e3624e2cf368f475ff3b5bc6e0bf9
# Push it to GitHub
git push --set-upstream origin backport/backport-16981-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
* add wlm support for scroll API Signed-off-by: Kaushal Kumar <[email protected]> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <[email protected]> * remove untagged tasks from WLM tracking Signed-off-by: Kaushal Kumar <[email protected]> * add UTs for invalid tasks Signed-off-by: Kaushal Kumar <[email protected]> * fix UT failures Signed-off-by: Kaushal Kumar <[email protected]> * rename a field in QueryGroupTask Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]>
* [WLM] Add wlm support for scroll API (#16981) * add wlm support for scroll API Signed-off-by: Kaushal Kumar <[email protected]> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <[email protected]> * remove untagged tasks from WLM tracking Signed-off-by: Kaushal Kumar <[email protected]> * add UTs for invalid tasks Signed-off-by: Kaushal Kumar <[email protected]> * fix UT failures Signed-off-by: Kaushal Kumar <[email protected]> * rename a field in QueryGroupTask Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> * remove breaking backward compatible changes Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]>
* add wlm support for scroll API Signed-off-by: Kaushal Kumar <[email protected]> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <[email protected]> * remove untagged tasks from WLM tracking Signed-off-by: Kaushal Kumar <[email protected]> * add UTs for invalid tasks Signed-off-by: Kaushal Kumar <[email protected]> * fix UT failures Signed-off-by: Kaushal Kumar <[email protected]> * rename a field in QueryGroupTask Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: Eugene Tolbakov <[email protected]>
Description
This change mitigates the warn level logs from
QueryGroupTask#getQueryGroupId
method when thequeryGroupId
isnull
. Currently all APIs which useSearchTask
orSearchShardTask
for task level resource tracking have to call thesetQueryGroupId
method otherwise this results in generating the log mentioned in the related issues.Related Issues
Resolves #16874
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.