Fix the compiler task status reporting for annotation processor #17063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Redko <[email protected]>
reta
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
@rishabhmaurya FYI, thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17063 +/- ##
============================================
+ Coverage 72.23% 72.29% +0.06%
- Complexity 65292 65371 +79
============================================
Files 5301 5301
Lines 303823 303823
Branches 44033 44033
============================================
+ Hits 219454 219654 +200
+ Misses 66344 66166 -178
+ Partials 18025 18003 -22 ☔ View full report in Codecov by Sentry. |
rishabhmaurya
approved these changes
Jan 20, 2025
cwperks
approved these changes
Jan 21, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 6e3d710) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Jan 21, 2025
…) (#17067) (cherry picked from commit 6e3d710) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jan 21, 2025
…search-project#17063) Signed-off-by: Andriy Redko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the compiler task status reporting for annotation processor. The Java compiler was reporting failures previously only because the
SecurityManagerwas preventing the writing of class files intobuildfolder. This was not very important because the annotation processing was always happening before (and this is what tests were checking). The change fixes the issue by outputting class files into temporary folder.Related Issues
Follow up on #16962
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.