Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CI's with Failed to load eclipse jdt formatter. #17172

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Jan 29, 2025

Description

Coming from diffplug/spotless#1783 (comment), fix failing CI's with Failed to load eclipse jdt formatter.

Related Issues

Sample Failing workflow https://github.com/opensearch-project/OpenSearch/actions/runs/13022093445/job/36324715880?pr=17153

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Prudhvi Godithi <[email protected]>
Copy link
Contributor

✅ Gradle check result for b598b16: SUCCESS

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.42%. Comparing base (1ca338d) to head (b598b16).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17172      +/-   ##
============================================
+ Coverage     72.37%   72.42%   +0.04%     
- Complexity    65537    65607      +70     
============================================
  Files          5298     5298              
  Lines        304603   304603              
  Branches      44187    44187              
============================================
+ Hits         220469   220612     +143     
+ Misses        66019    65905     -114     
+ Partials      18115    18086      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh msfroh merged commit 3c55a31 into opensearch-project:main Jan 29, 2025
66 of 67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-17172-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3c55a311a3305f64bbfc9548569bd36469b867a7
# Push it to GitHub
git push --set-upstream origin backport/backport-17172-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-17172-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants