Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of transitive shaded dependency #17194

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

andrross
Copy link
Member

@yupeng9 Looks like we missed one usage of shaded immutable map.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@yupeng9
Copy link
Contributor

yupeng9 commented Jan 29, 2025

yes, good catch!

@yupeng9
Copy link
Contributor

yupeng9 commented Jan 29, 2025

curious, how was it detected and does it have some effect?

Copy link
Contributor

✅ Gradle check result for 37d8ade: SUCCESS

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.44%. Comparing base (cd149a9) to head (37d8ade).
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17194      +/-   ##
============================================
+ Coverage     72.41%   72.44%   +0.03%     
- Complexity    65626    65784     +158     
============================================
  Files          5306     5319      +13     
  Lines        304927   305717     +790     
  Branches      44257    44352      +95     
============================================
+ Hits         220804   221487     +683     
- Misses        66007    66092      +85     
- Partials      18116    18138      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh msfroh merged commit 20a58eb into opensearch-project:main Jan 30, 2025
55 of 56 checks passed
@andrross
Copy link
Member Author

curious, how was it detected and does it have some effect?

@yupeng9 It was not causing any problem. I just happened to notice it after I merged the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants