Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Unify precomputation of aggregations behind a common API #17197

Merged
merged 1 commit into from
Jan 30, 2025

Unify precomputation of aggregations behind a common API (#16733)

a751d6d
Select commit
Loading
Failed to load commit list.
Merged

[Backport 2.x] Unify precomputation of aggregations behind a common API #17197

Unify precomputation of aggregations behind a common API (#16733)
a751d6d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2025 in 0s

72.00% (target 70.00%)

View this Pull Request on Codecov

72.00% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 83.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 72.00%. Comparing base (2187369) to head (a751d6d).
Report is 5 commits behind head on 2.x.

Files with missing lines Patch % Lines
...rch/search/aggregations/metrics/MinAggregator.java 60.00% 2 Missing and 2 partials ⚠️
...rch/aggregations/metrics/ValueCountAggregator.java 66.66% 2 Missing and 1 partial ⚠️
...ket/terms/GlobalOrdinalsStringTermsAggregator.java 89.47% 1 Missing and 1 partial ⚠️
...rch/search/aggregations/metrics/MaxAggregator.java 80.00% 1 Missing and 1 partial ⚠️
...rch/search/aggregations/metrics/AvgAggregator.java 85.71% 1 Missing ⚠️
...rch/search/aggregations/metrics/SumAggregator.java 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #17197      +/-   ##
============================================
+ Coverage     71.98%   72.00%   +0.02%     
+ Complexity    65987    65982       -5     
============================================
  Files          5341     5341              
  Lines        307114   307152      +38     
  Branches      44824    44822       -2     
============================================
+ Hits         221068   221171     +103     
+ Misses        67608    67576      -32     
+ Partials      18438    18405      -33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov