[Bug Fix] Fix assistant plugin override issue and return dataSourceId in context #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Songkan Tang <[email protected]>
songkant-aws
requested review from
lezzago,
AWSHurneyt,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya and
riysaxen-amzn
as code owners
songkant-aws
changed the title
|
@riysaxen-amzn @amsiglan Could you help to take a look at this bug fix? |
amsiglan
approved these changes
Sep 20, 2024
AWSHurneyt
approved these changes
Sep 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
#1102) Signed-off-by: Songkan Tang <[email protected]> (cherry picked from commit 8369a3d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Sep 21, 2024
#1102) (#1103) (cherry picked from commit 8369a3d) Signed-off-by: Songkan Tang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In previous context aware analysis PR, the optional assistantPlugin overrides optional dataSourceManagement PR, which caused the dataSource disabled.
Also, there is possibly requirement to filter by dataSourceId. Hence, return additional dataSourceId in context.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.