Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add field validation for anomaly detector results (#1126) #1194

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

heilmela
Copy link
Contributor

@heilmela heilmela commented Jan 23, 2025

Description

adds the correct field validation for detector results. Right now its not possible to create monitors for anomaly detectors since features are not correctly fetched due to missing field validations of the query.

Issues Resolved

#1126

Check List

  • [ x] New functionality includes testing.
    • [x ] All tests pass
  • [ x] New functionality has been documented.
    • [ x] New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kaituo
Copy link
Contributor

kaituo commented Feb 5, 2025

pinged @riysaxen-amzn to help review.

@kaituo
Copy link
Contributor

kaituo commented Feb 6, 2025

pinged @AWSHurneyt to help take a look.

@AWSHurneyt AWSHurneyt merged commit eb8a099 into opensearch-project:main Feb 6, 2025
10 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2025
Signed-off-by: Laurin Heilmeyer <[email protected]>
Co-authored-by: Laurin Heilmeyer <[email protected]>
(cherry picked from commit eb8a099)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Feb 6, 2025
#1207)

(cherry picked from commit eb8a099)

Signed-off-by: Laurin Heilmeyer <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Laurin Heilmeyer <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 12, 2025
Signed-off-by: Laurin Heilmeyer <[email protected]>
Co-authored-by: Laurin Heilmeyer <[email protected]>
(cherry picked from commit eb8a099)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants