Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete workflow metadata on deleting a detector #1766

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Delete workflow metadata on deleting a detector #1766

merged 5 commits into from
Jan 16, 2025

Conversation

nishtham-amazon
Copy link
Contributor

@nishtham-amazon nishtham-amazon commented Jan 7, 2025 •
edited
Loading

Description

Metadata is not fully cleaned up in the alerting config index when a detector is deleted

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

eirsep
eirsep requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@eirsep eirsep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz add integ tests which verifies deletion of metadata docs from system index post workflow deletion when deleteMonitor Deltion flag is true and same for false.

@nishtham-amazon
Copy link
Contributor Author

plz add integ tests which verifies deletion of metadata docs from system index post workflow deletion when deleteMonitor Deltion flag is true and same for false.

Done

nishtham-amazon and others added 5 commits January 16, 2025 13:35
@nishtham-amazon
Delete workflow metadata on deleting workflow
d14b1cc 
Signed-off-by: Nishtha Mehrotra <[email protected]>
Added UTs for ensuring monitor workflow metadata is deleted on deleti…
722de74 
…ng monitor workflow

Signed-off-by: Nishtha Mehrotra <[email protected]>
Updated documentation notes
bfaa80d 
Signed-off-by: Nishtha Mehrotra <[email protected]>
Updated error logs
6f5b955 
Signed-off-by: Nishtha Mehrotra <[email protected]>
Updated assert
b4bfcd2 
Signed-off-by: Nishtha Mehrotra <[email protected]>
@eirsep eirsep merged commit 03595f8 into opensearch-project:main Jan 16, 2025
13 of 18 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 16, 2025
@github-actions
Delete workflow metadata on deleting a detector (#1766)
111738e 
* Delete workflow metadata on deleting workflow

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Added UTs for ensuring monitor workflow metadata is deleted on deleting monitor workflow

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated documentation notes

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated error logs

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated assert

Signed-off-by: Nishtha Mehrotra <[email protected]>

---------

Signed-off-by: Nishtha Mehrotra <[email protected]>
Co-authored-by: Nishtha Mehrotra <[email protected]>
(cherry picked from commit 03595f8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 16, 2025
Open
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 16, 2025
@github-actions
Delete workflow metadata on deleting a detector (#1766)
ce0e193 
* Delete workflow metadata on deleting workflow

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Added UTs for ensuring monitor workflow metadata is deleted on deleting monitor workflow

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated documentation notes

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated error logs

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated assert

Signed-off-by: Nishtha Mehrotra <[email protected]>

---------

Signed-off-by: Nishtha Mehrotra <[email protected]>
Co-authored-by: Nishtha Mehrotra <[email protected]>
(cherry picked from commit 03595f8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 16, 2025
Open
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 16, 2025
@github-actions
Delete workflow metadata on deleting a detector (#1766)
2bfdab8 
* Delete workflow metadata on deleting workflow

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Added UTs for ensuring monitor workflow metadata is deleted on deleting monitor workflow

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated documentation notes

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated error logs

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated assert

Signed-off-by: Nishtha Mehrotra <[email protected]>

---------

Signed-off-by: Nishtha Mehrotra <[email protected]>
Co-authored-by: Nishtha Mehrotra <[email protected]>
(cherry picked from commit 03595f8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 16, 2025
Open
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 16, 2025
@github-actions
Delete workflow metadata on deleting a detector (#1766)
45f3e16 
* Delete workflow metadata on deleting workflow

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Added UTs for ensuring monitor workflow metadata is deleted on deleting monitor workflow

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated documentation notes

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated error logs

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated assert

Signed-off-by: Nishtha Mehrotra <[email protected]>

---------

Signed-off-by: Nishtha Mehrotra <[email protected]>
Co-authored-by: Nishtha Mehrotra <[email protected]>
(cherry picked from commit 03595f8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 16, 2025
Open
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 16, 2025
@github-actions
Delete workflow metadata on deleting a detector (#1766)
6456b33 
* Delete workflow metadata on deleting workflow

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Added UTs for ensuring monitor workflow metadata is deleted on deleting monitor workflow

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated documentation notes

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated error logs

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated assert

Signed-off-by: Nishtha Mehrotra <[email protected]>

---------

Signed-off-by: Nishtha Mehrotra <[email protected]>
Co-authored-by: Nishtha Mehrotra <[email protected]>
(cherry picked from commit 03595f8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riysaxen-amzn riysaxen-amzn riysaxen-amzn approved these changes

@eirsep eirsep eirsep approved these changes

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@AWSHurneyt AWSHurneyt Awaiting requested review from AWSHurneyt AWSHurneyt is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

@bowenlan-amzn bowenlan-amzn Awaiting requested review from bowenlan-amzn bowenlan-amzn is a code owner

@rishabhmaurya rishabhmaurya Awaiting requested review from rishabhmaurya rishabhmaurya is a code owner

@engechas engechas Awaiting requested review from engechas engechas is a code owner

@jowg-amazon jowg-amazon Awaiting requested review from jowg-amazon jowg-amazon is a code owner

@amsiglan amsiglan Awaiting requested review from amsiglan amsiglan is a code owner

@goyamegh goyamegh Awaiting requested review from goyamegh goyamegh is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.15 backport 2.16 backport 2.17 backport 2.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nishtham-amazon @eirsep @riysaxen-amzn