Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 3.0] Added alpha1 qualifier. Updated shadow plugin reference. #1786

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AWSHurneyt
Copy link
Collaborator

Description

  1. Added alpha1 qualifier.
  2. Updated shadow plugin reference.

To align with common utils - opensearch-project/common-utils#775

Related Issues

opensearch-project/opensearch-build#5267
opensearch-project/opensearch-build#3747

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@@ -3,7 +3,6 @@
* SPDX-License-Identifier: Apache-2.0
*/

import com.github.jengelman.gradle.plugins.shadow.ShadowPlugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my check on JS plugin, gradleup did not remove this com.github.jengelman.gradle.plugins.shadow.ShadowPlugin, just the namespace of the plugin on gradle mirror is changed.

I just update the apply section and it still pass the assemble.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for that context! I'll try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants