Update codecs to Apache Lucene 9.12.0 #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
requested review from
andrross,
nknize and
sarthakaggarwal97
as code owners
Signed-off-by: Andriy Redko <[email protected]>
|
Thanks @reta for raising this. Would you please look into BWC tests that are failing. Looks to be a compile time issue. |
Thanks for looking @sarthakaggarwal97 , I am off today but will get to it tomorrow , thanks! |
src/main/java/org/opensearch/index/codec/customcodecs/CustomCodecPlugin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/index/codec/customcodecs/ZstdNoDictCompressionMode.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/index/codec/customcodecs/Lucene912QatStoredFieldsFormat.java
Show resolved
Hide resolved
Signed-off-by: Andriy Redko <[email protected]>
5 tasks
|
Apologies, posted my comment on the backport PR. Please take a look: #199 (comment) |
No worries, updated both PRs, thanks @sarthakaggarwal97 ! |
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
|
@sarthakaggarwal97 mind please approving this one as well? thank you! |
sarthakaggarwal97
approved these changes
Oct 24, 2024
|
Thanks @reta for taking this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update codecs to Apache Lucene 9.12.0
Related Issues
Closes #197
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.