Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating lucene version to lucene 10 #216

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RS146BIJAY
Copy link

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon
Copy link
Member

@RS146BIJAY I am not sure what happened to the github checks.

But on my local it is clear that custom codecs needs to move to lucene10, so you can ignore the lucene9 failure.

@reta might have more context on this but for now I cant find the location for org.apache.lucene.codecs.lucene912.Lucene912Codec assume it changes places just like the shadow plugin. Thanks.

@reta
Copy link
Collaborator

reta commented Jan 28, 2025

@peterzhuamazon see please https://github.com/opensearch-project/OpenSearch/pull/16366/files#diff-bdc255f9e65251190ee8d5faeef7535d74081edd39080b5da4d623f63a7ea794, there are quite some changes to be done

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Jan 28, 2025

The eclipse issue is more or less related to the incident here:

I kept re-running on my local and 3 out of 10 times it will have this connectivity issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants