Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suggestedAction could be null #104

Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix: suggestedAction could be null #104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d2fce8
fix: suggestedAction could be null
SuZhou-Joe Jan 19, 2024
b4728bb
feat: update
SuZhou-Joe Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions server/parsers/basic_input_output_parser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,4 +194,8 @@ describe('parseSuggestedActions', () => {
expect(parseSuggestedActions('')).toEqual([]);
expect(parseSuggestedActions((null as unknown) as string)).toEqual([]);
});

it('should not throw error when suggested actions is "null"', () => {
expect(parseSuggestedActions('null')).toEqual([]);
});
});
8 changes: 8 additions & 0 deletions server/parsers/basic_input_output_parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ export const parseSuggestedActions = (value: string): string[] => {
suggestedActions = [];
}

/**
* The suggestedOutputString may be 'null'
* Fail fast here.
*/
if (!suggestedActions) {
return [];
}

if (suggestedActions.length) {
wanglam marked this conversation as resolved.
Show resolved Hide resolved
if (isStringArray(suggestedActions)) {
return suggestedActions;
Expand Down
Loading