-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate maps multi data source display #651
Deprecate maps multi data source display #651
Conversation
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
9c66c0f
to
fb7a433
Compare
@junqiu-lei LGTM! |
The E2E test failure is due to new version cypress using higher memory crashes the github CI runner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-651-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a433766e74dd2ac1583d376c48ca3b6f4a8935a3
# Push it to GitHub
git push --set-upstream origin backport/backport-651-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit a433766) Signed-off-by: Junqiu Lei <[email protected]>
(cherry picked from commit a433766) Signed-off-by: Junqiu Lei <[email protected]>
Description
Deprecate maps multi data source display when
data_source
is enabled based on Trineo Maps UX mock.Issues Resolved
Part of #649
UI Changes
Before
After
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.