-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Sources: Installed Integrations Table #1530
Data Sources: Installed Integrations Table #1530
Conversation
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Marking ready for review -- Still not going to backport until the remainder of the necessary work is done but it's usable in the current state |
case 'partially-available': | ||
return <EuiHealth color="warning">Partially Available</EuiHealth>; | ||
default: | ||
return <EuiHealth color="danger">Critical</EuiHealth>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: it might be worthwhile to make a string enum for the status type and comprehensively cover all the branches, using default for critical is tech debt
Signed-off-by: Simeon Widdis <[email protected]>
Test failures are upstream OSD breakage, looks like the culprit is opensearch-project/OpenSearch-Dashboards#6060. Fix: #1533 Lint issues are also happening, tracking issue here: #1363. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
==========================================
- Coverage 57.74% 57.04% -0.70%
==========================================
Files 362 349 -13
Lines 13301 12729 -572
Branches 3461 3278 -183
==========================================
- Hits 7680 7261 -419
+ Misses 5562 5414 -148
+ Partials 59 54 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…/Swiddis/dashboards-observability into feature/ds-installed-integ-table
Signed-off-by: Simeon Widdis <[email protected]>
Accidentally merged #1544 first -- Since that PR is a superset of this one I'll close this one and make a followup for issues |
Description
First PR in a coming series adding installed integrations to the data sources viewer. Some WIP upcoming parts:
This PR is mostly here to help get some initial work in for preliminary looks at the 2.13 release, but isn't release-ready yet so I'll hold off on the backport label for now.
Issues Resolved
N/A (need to write an issue for the feature).
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.