[BUG]Csv report generation had missing nested Fields

[sumukhswamy]

Description

On generating a CSV report from a saved search in Dashboards, nestsed fields for the index pattern was not getting parsed in the picture below

RCA:
the code piece handling the nested fields only checked if the fields had a key with a . in them, it was ignoring the fields which had an array of objects to be added to the CSV file, the fix handles the nested array objects which are needed as a part of the nested fields
The fix handles all nested fields which were getting truncated

Issues Resolved

#375

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[joshuali925]

seems this only does it one level, does it work if the data is more nested like

{
  "a": {
    "b": {
      "c": [
        {
          "d": [{ "e": 1 }, { "e": 2 }]
        },
        {
          "d": [{ "e": 3 }, { "e": 4 }]
        }
      ]
    }
  }
}

and could you add some unit tests?

[sumukhswamy]

have updated it

[joshuali925]

i don't really see any logic change in the new commits?

[ps48]

Adding more comments here:

1. This may be still only working with one level of array nesting
2. Best way to check is by adding multi-level nested array of objects
3. Nit - Object.keys(data) is looped twice can just keep it one.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.22%. Comparing base (2f7ae07) to head (92af2c8).
Report is 28 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   71.05%   71.22%   +0.16%     
==========================================
  Files          31       31              
  Lines        2011     2054      +43     
  Branches      432      453      +21     
==========================================
+ Hits         1429     1463      +34     
- Misses        579      585       +6     
- Partials        3        6       +3     

Flag	Coverage Δ
dashboards-report	71.22% <ø> (+0.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joshuali925]

as I commented here #502 (comment), this doesn't recurse, so it only flattens one level. For example, discover shows

{ "a": { "b": { "c": [ { "d": [{ "e": 1 }, { "e": 2 }] }, { "d": [{ "e": 3 }, { "e": 4 }] } ] } } }

as

a.b.c.d.e:1, 2, 3, 4

but reporting csv shows

_source.a.b.c
"[{""d"":[{""e"":1},{""e"":2}]},{""d"":[{""e"":3},{""e"":4}]}]"

but it's definitely better than not showing up at all