[Bug] Removed defualt option in MDS selector #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sumukhswamy <[email protected]>
sumukhswamy
requested review from
macohen,
mingshl,
msfroh,
noCharger and
sejli
as code owners
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
sejli
approved these changes
Oct 15, 2024
github-actions bot
added a commit
that referenced
this pull request
Oct 16, 2024
* removed default option which was causing issue to fetch index Signed-off-by: sumukhswamy <[email protected]> * removed console logs Signed-off-by: sumukhswamy <[email protected]> * updated api calls to not trigger on initial load Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit 017e1dc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sumukhswamy
pushed a commit
that referenced
this pull request
Oct 16, 2024
* removed default option which was causing issue to fetch index * removed console logs * updated api calls to not trigger on initial load --------- (cherry picked from commit 017e1dc) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Empty default option was fetching from local cluster on load
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.