Skip to content

Commit

Permalink
better naming
Browse files Browse the repository at this point in the history
Signed-off-by: Santhosh Gandhe <[email protected]>
  • Loading branch information
san81 committed Jan 13, 2025
1 parent 0c34119 commit cc82281
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ public interface PluginConfigValueTranslator {

String getPrefix();

PluginConfigVariable translateVariable(final String value);
PluginConfigVariable translateToPluginConfigVariable(final String value);
}
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public <T> T translate(final JsonParser jsonParser, final Class<T> destinationTy
.map(entry -> {
final String valueReferenceKey = entry.getKey().group(VALUE_REFERENCE_KEY);
if (destinationType.equals(PluginConfigVariable.class)) {
return (T) entry.getValue().translateVariable(valueReferenceKey);
return (T) entry.getValue().translateToPluginConfigVariable(valueReferenceKey);
} else {
return objectMapper.convertValue(
entry.getValue().translate(valueReferenceKey), destinationType);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public String getPrefix() {
}

@Override
public PluginConfigVariable translateVariable(String value) {
public PluginConfigVariable translateToPluginConfigVariable(String value) {
final Matcher matcher = SECRETS_REF_PATTERN.matcher(value);
if (!matcher.matches()) {
throw new IllegalArgumentException(String.format(
Expand Down

0 comments on commit cc82281

Please sign in to comment.