Add bug fixes and improvements to DDB source #3559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aiden Dai <[email protected]>
daixba
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
Signed-off-by: Aiden Dai <[email protected]>
graytaylor0
approved these changes
Oct 30, 2023
dinujoh
approved these changes
Oct 31, 2023
| @@ -37,30 +46,37 @@ public class DataFileLoader implements Runnable { | |||
| */ | |||
| private static final int DEFAULT_CHECKPOINT_INTERVAL_MILLS = 2 * 60_000; | |||
|
|
|||
| static final Duration BUFFER_TIMEOUT = Duration.ofSeconds(60); | |||
| static final int DEFAULT_BUFFER_BATCH_SIZE = 1_000; | |||
There was a problem hiding this comment.
Both number won't make too much differences.
There will be retries after timeout anyway. 1000 is the batch size we used for reading file and reading stream data, so we just use the same.
| @@ -128,7 +150,9 @@ public void run() { | |||
| int lineCount = 0; | |||
| int lastLineProcessed = 0; | |||
|
|
|||
| try (GZIPInputStream gzipInputStream = new GZIPInputStream(s3ObjectReader.readFile(bucketName, key))) { | |||
| try { | |||
| InputStream inputStream = objectReader.readFile(bucketName, key); | |||
There was a problem hiding this comment.
nit:
try (
InputStream inputStream = objectReader.readFile(bucketName, key);
GZIPInputStream gzipInputStream = new GZIPInputStream(inputStream);
BufferedReader reader = new BufferedReader(new InputStreamReader(gzipInputStream));
) {
..
}
There was a problem hiding this comment.
I didn't know we could do that. I thought it can only be one.
| LOG.info("Complete loading s3://{}/{}", bucketName, key); | ||
| } catch (Exception e) { | ||
| } catch (IOException e) { |
There was a problem hiding this comment.
Why is this exception scoped down ? How are we handling other exception ?
There was a problem hiding this comment.
You're right. There may be other exceptions. Since this is merged, I will update this in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix below bugs:
out of range of intfor item countsMake below improvements:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.