Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update end-to-end tests to use the release Docker image or release archive #3576

Merged

Conversation

dlvenable
Copy link
Member

Description

This PR updates the end-to-end tests to make use release artifacts. This moves toward replacing the existing smoke tests with our end-to-end tests instead, though it doesn't complete that transition.

With this PR, our end-to-end test will use release artifacts. This means that our PRs will run tests against actual artifacts instead of test-specific artifacts.

This PR:

  • Adds a new endToEndJavaVersion option named docker which runs using the release Docker image.
  • Updates the custom end-to-end Docker image to use the release tar.gz instead of building custom packaging.
  • Run end-to-end tests using the release Docker image by default.
  • Adds a buildSrc to start sharing more logic between classes.
  • Makes more use of tasks.register() which allows Gradle to evaluate the tasks when needed.

In order to make this work, I changed each test sub-project to register tasks from a configuration object. This configuration object has the correct configurations for creating the tests. Then the Gradle build will use the configurations to register the tasks. This works better than the old approach which called functions from the tasks. For one, it allows us to use tasks.register() and thus evaluate the tasks as needed.

Issues Resolved

Resolves #3566

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…mage with a specific Java version. Resolves opensearch-project#3566

Signed-off-by: David Venable <[email protected]>
@dlvenable dlvenable changed the title Update end-to-end tests to use the release Docker image or a custom i… Update end-to-end tests to use the release Docker image or release archive Nov 1, 2023
Copy link
Collaborator

@oeyh oeyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dlvenable dlvenable merged commit c53598f into opensearch-project:main Nov 3, 2023
42 checks passed
@dlvenable dlvenable deleted the 3566-end-to-end-docker branch November 10, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update end-to-end tests to run from the released Docker image
3 participants