Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass custom metric prefix if present to AbstractBuffer when using KafkaBuffer #3638

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

dinujoh
Copy link
Member

@dinujoh dinujoh commented Nov 12, 2023

Pass custom metric prefix if present to AbstractBuffer when using KafkaBuffer

Description

Pass custom metric prefix if present to AbstractBuffer when using KafkaBuffer. All the AbstractBuffer metrics should have customPrefix with KafkaBuffer. Also using consumer metrics for emptyCheckingConsumers.

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dinujoh dinujoh changed the title Pass custom metric prefix if present to AbstractBuffer when using Kaf… Pass custom metric prefix if present to AbstractBuffer when using KafkaBuffer Nov 12, 2023
kkondaka
kkondaka previously approved these changes Nov 12, 2023
@oeyh
Copy link
Collaborator

oeyh commented Nov 12, 2023

Build is failing with this error:

/home/runner/work/data-prepper/data-prepper/data-prepper-plugins/kafka-plugins/src/test/java/org/opensearch/dataprepper/plugins/kafka/buffer/KafkaBufferTest.java:154: error: constructor KafkaBuffer in class KafkaBuffer cannot be applied to given types;
            return new KafkaBuffer(pluginSetting, bufferConfig, pluginFactory, acknowledgementSetManager, pluginMetrics, null, awsCredentialsSupplier, circuitBreaker);
                   ^
  required: PluginSetting,KafkaBufferConfig,PluginFactory,AcknowledgementSetManager,ByteDecoder,AwsCredentialsSupplier,CircuitBreaker
  found: PluginSetting,KafkaBufferConfig,PluginFactory,AcknowledgementSetManager,PluginMetrics,<null>,AwsCredentialsSupplier,CircuitBreaker
  reason: actual and formal argument lists differ in length

@dinujoh dinujoh merged commit 504485c into opensearch-project:main Nov 12, 2023
41 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants